Add profile binding unit tests #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
saschagrunert
commented
Apr 15, 2021
| @@ -173,7 +173,7 @@ func (p *podSeccompBinder) getSeccompProfile( | |||
| err = util.Retry( | |||
| func() (retryErr error) { | |||
| seccompProfile, retryErr = p.GetSeccompProfile(ctx, key) | |||
| if err != nil { | |||
| if retryErr != nil { | |||
There was a problem hiding this comment.
Whoops, that's a bug.
Adding unit test cases to the binding webhook. This also fixes a bug where the binding error did not get returned correctly which would cause the webhook to crash. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
binding-unit-tests
branch
from
da41677
to
09e51b7
Compare
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 30.37% 38.08% +7.70%
==========================================
Files 20 20
Lines 948 948
==========================================
+ Hits 288 361 +73
+ Misses 650 572 -78
- Partials 10 15 +5 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Adding unit test cases to the binding webhook.
This also fixes a bug where the binding error did not get returned
correctly which would cause the webhook to crash.
Which issue(s) this PR fixes:
None
Does this PR have test?
Yes
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?