Add initial metrics support #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the necessary code infrastructure to allow serving metrics
within the operator daemonset (spod). The metrics are for now served
unencrypted on port :8081. An additional service `metrics` can be used
for scraping from prometheus (by using the auto-discover plugin
`kubernetes_sd_configs` or a `ServiceMonitor` together with the
prometheus-operator).
This patch features a sample metric counter
`security_profiles_operator_seccomp_profile`, which can be distinguished
by the labels `update` and `delete`. For example, if we create 4 new
profiles and delete them afterwards, then the output should look like:
```
\# HELP security_profiles_operator_seccomp_profile Counter about seccomp profile operations.
\# TYPE security_profiles_operator_seccomp_profile counter
security_profiles_operator_seccomp_profile{operation="delete"} 4
security_profiles_operator_seccomp_profile{operation="update"} 4
```
Things to be done after this patch:
- decide which metrics we would like to implement
- provide documentation around the feature
- add metric related e2e tests
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
+ Coverage 38.00% 39.69% +1.69%
==========================================
Files 20 22 +2
Lines 950 985 +35
==========================================
+ Hits 361 391 +30
- Misses 574 579 +5
Partials 15 15 |
JAORMX
approved these changes
Apr 27, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds the necessary code infrastructure to allow serving metrics
within the operator daemonset (spod). The metrics are for now served
unencrypted on port :8081. An additional service
metricscan be usedfor scraping from prometheus (by using the auto-discover plugin
kubernetes_sd_configsor aServiceMonitortogether with theprometheus-operator).
This patch features a sample metric counter
security_profiles_operator_seccomp_profile, which can be distinguishedby the labels
updateanddelete. For example, if we create 4 newprofiles and delete them afterwards, then the output should look like:
Things to be done after this patch:
Which issue(s) this PR fixes:
Refers to #276
Does this PR have test?
Yes
Special notes for your reviewer:
Does this PR introduce a user-facing change?