Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceMonitor documentation #460

Merged
merged 1 commit into from
May 21, 2021

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This patch adds documentation about how to use the automatically
deployed ServiceMonitor with OpenShift as example platform.

Which issue(s) this PR fixes:

Refers to #276

Does this PR have test?

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added documentation how to use the automatically deployed `ServiceMonitor` with OpenShift as example platform.

This patch adds documentation about how to use the automatically
deployed `ServiceMonitor` with OpenShift as example platform.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #460 (4b51ec5) into master (2f85787) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   36.48%   36.48%           
=======================================
  Files          23       23           
  Lines        1069     1069           
=======================================
  Hits          390      390           
  Misses        664      664           
  Partials       15       15           

@cmurphy
Copy link
Contributor

cmurphy commented May 21, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0cee60c into kubernetes-sigs:master May 21, 2021
@saschagrunert saschagrunert deleted the metrics-docs branch May 25, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants