Fix log enricher read and automatically add /dev/kmsg device
#479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
approved
saschagrunert
changed the title
/dev/kmsg device
k8s-ci-robot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
==========================================
- Coverage 37.92% 37.79% -0.14%
==========================================
Files 23 23
Lines 1110 1114 +4
==========================================
Hits 421 421
- Misses 674 678 +4
Partials 15 15 |
|
/test pull-security-profiles-operator-test-e2e |
2 similar comments
|
/test pull-security-profiles-operator-test-e2e |
|
/test pull-security-profiles-operator-test-e2e |
|
/retest |
When using CRI-O, we can utilize the annotation `io.kubernetes.cri-o.Devices` to correctly mount the device into the container. This means we do not rely on a symlink any more and can use the device directly. The enricher read has been fixed because one read always returns a full line which makes the offset calculation obsolete. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
enricher-fix
branch
from
98fc2dd
to
dfa7067
Compare
|
Rebased, let's see if the tests pass now otherwise it's a bug in the PR. |
|
/retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
When using CRI-O, we can utilize the annotation
io.kubernetes.cri-o.Devicesto correctly mount the device into thecontainer. This means we do not rely on a symlink any more and can use
the device directly.
The enricher read has been fixed because one read always returns a full
line which makes the offset calculation obsolete.
Which issue(s) this PR fixes:
None
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?