Cache pods and container IDs in log enricher #509
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
|
/test pull-security-profiles-operator-test-e2e |
| @@ -77,7 +88,7 @@ func (e *Enricher) getNodeContainers(logger logr.Logger, nodeName string) (map[s | |||
| continue | |||
| } | |||
|
|
|||
| containers[rawContainerID] = containerInfo{ | |||
| containers[rawContainerID] = &containerInfo{ | |||
There was a problem hiding this comment.
why don't we update the cache already here? This will cache all the container infos that have been found already, wouldn't it?
There was a problem hiding this comment.
Yes I think this makes sense, changed as suggested 👍
| @@ -27,23 +30,39 @@ import ( | |||
| "sigs.k8s.io/security-profiles-operator/internal/pkg/config" | |||
| ) | |||
|
|
|||
| const defaultCacheTimeout time.Duration = 6 * time.Hour | |||
There was a problem hiding this comment.
Given the ephemeral nature of containers, maybe we should choose a lower cache timeout. e.g. only a couple of hours maybe? or even less, what do you think? We should document our reasoning in comments here.
There was a problem hiding this comment.
Yeah I think we should reduce it, I've chosen 1 hour. I also added a comment that it's nothing more than a rough guess 🤷♂️
There was a problem hiding this comment.
Right, at least now people won't wonder why a value was chosen. Maybe one day we'll have enough usage and data for the operator to choose a value based on data :)
We now use a cache and a default timeout of 6 hours to cache the container info as well as the PIDs. This should speedup the enricher in general. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
We now use a cache and a default timeout of 6 hours to cache the
container info as well as the PIDs. This should speedup the enricher in
general.
Which issue(s) this PR fixes:
None
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?