Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for log enricher profile recording #513

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 30, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

Implements profile recording by using the log enricher.

It also fixes a couple of issues with the log enricher:

Which issue(s) this PR fixes:

PoC of #510

Does this PR have test?

None

Special notes for your reviewer:

Possible follow-upds:

  • Update the docs to cover the new feature and ProfileRecording field
  • Use GRPC streaming for the syscalls (open a stream on the beginning of the enricher and use that one for pushing the syscalls)

Does this PR introduce a user-facing change?

Added support for recording profiles by using the log enricher.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 30, 2021
@saschagrunert saschagrunert changed the title Add support for log enricher profile recording WIP: Add support for log enricher profile recording Jun 30, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 30, 2021
@saschagrunert saschagrunert force-pushed the log-recording branch 7 times, most recently from 0d40186 to 09ec20d Compare June 30, 2021 13:48
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021

Codecov Report

Merging #513 (04143f8) into master (cd71f46) will decrease coverage by 1.14%.
The diff coverage is 43.58%.

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
- Coverage   44.25%   43.11%   -1.15%     
==========================================
  Files          24       24              
  Lines        1236     1285      +49     
==========================================
+ Hits          547      554       +7     
- Misses        652      692      +40     
- Partials       37       39       +2     

@saschagrunert saschagrunert force-pushed the log-recording branch 6 times, most recently from 1e0ff32 to 73eea5b Compare July 1, 2021 06:58
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert saschagrunert force-pushed the log-recording branch 3 times, most recently from 29144fd to b918a29 Compare July 1, 2021 09:13
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert saschagrunert force-pushed the log-recording branch 2 times, most recently from 670bc55 to 2a2ee25 Compare July 2, 2021 09:09
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert saschagrunert force-pushed the log-recording branch 2 times, most recently from 64e9bdb to b4ae46c Compare July 2, 2021 10:03
@saschagrunert saschagrunert changed the title WIP: Add support for log enricher profile recording Add support for log enricher profile recording Jul 2, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2021
@saschagrunert
Copy link
Member Author

I'll update the docs in a follow-up PR.

@saschagrunert
Copy link
Member Author

/test pull-security-profiles-operator-test-e2e

@saschagrunert
Copy link
Member Author

/test pull-security-profiles-operator-test-e2e

1 similar comment
@saschagrunert
Copy link
Member Author

/test pull-security-profiles-operator-test-e2e

@saschagrunert
Copy link
Member Author

/retest

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a05df79 into kubernetes-sigs:master Jul 2, 2021
@saschagrunert saschagrunert deleted the log-recording branch July 2, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants