-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for log enricher profile recording #513
Add support for log enricher profile recording #513
Conversation
0d40186
to
09ec20d
Compare
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
- Coverage 44.25% 43.11% -1.15%
==========================================
Files 24 24
Lines 1236 1285 +49
==========================================
+ Hits 547 554 +7
- Misses 652 692 +40
- Partials 37 39 +2 |
1e0ff32
to
73eea5b
Compare
/retest |
29144fd
to
b918a29
Compare
/retest |
b918a29
to
6269d8f
Compare
670bc55
to
2a2ee25
Compare
/retest |
64e9bdb
to
b4ae46c
Compare
I'll update the docs in a follow-up PR. |
/test pull-security-profiles-operator-test-e2e |
b4ae46c
to
978db02
Compare
/test pull-security-profiles-operator-test-e2e |
1 similar comment
/test pull-security-profiles-operator-test-e2e |
978db02
to
fd26441
Compare
/retest |
fd26441
to
04143f8
Compare
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
04143f8
to
a818fd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implements profile recording by using the log enricher.
It also fixes a couple of issues with the log enricher:
containerID
here, which should berawContainerID
:security-profiles-operator/internal/pkg/daemon/enricher/container.go
Line 100 in cd71f46
containers
for every loop:security-profiles-operator/internal/pkg/daemon/enricher/container.go
Line 66 in cd71f46
containers
map and only rely on the cache to stay safe:security-profiles-operator/internal/pkg/daemon/enricher/container.go
Line 58 in cd71f46
Which issue(s) this PR fixes:
PoC of #510
Does this PR have test?
None
Special notes for your reviewer:
Possible follow-upds:
ProfileRecording
fieldDoes this PR introduce a user-facing change?