Add syslog support to log enricher #531
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
==========================================
+ Coverage 44.06% 44.12% +0.06%
==========================================
Files 25 25
Lines 1305 1310 +5
==========================================
+ Hits 575 578 +3
- Misses 694 695 +1
- Partials 36 37 +1 |
This adds support for `/var/log/syslog` log files if auditd is not available on a node. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
/test pull-security-profiles-operator-build-image |
|
uhm... not sure if the syslog file is available in RHCOS, this might make it fail... let me verify |
Is auditd not enabled in RHCOS? |
|
@saschagrunert auditd is enabled in RHCOS. But this PR adds by default the bind-mount for syslog, which will fail and not deploy properly in RHCOS. |
No, it just mounts the |
| Name: "host-syslog-volume", | ||
| VolumeSource: v1.VolumeSource{ | ||
| HostPath: &v1.HostPathVolumeSource{ | ||
| Path: filepath.Dir(config.SyslogLogPath), |
There was a problem hiding this comment.
ah! I missed that this gets filepath.Dir. This is fine!
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
e2e tests are broken right now, merging. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds support for
/var/log/sysloglog files if auditd is not available on a node.Which issue(s) this PR fixes:
None
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?