-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate seccomp profile from v1alpha1
to v1beta1
#674
Graduate seccomp profile from v1alpha1
to v1beta1
#674
Conversation
59dd831
to
e5330ef
Compare
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
e5330ef
to
dcbf699
Compare
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
=======================================
Coverage 51.67% 51.67%
=======================================
Files 31 31
Lines 2061 2061
=======================================
Hits 1065 1065
Misses 943 943
Partials 53 53 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that seccomp in general has been stable enough to promote. And it would make a nice 0.4.0 release highlight. The only thing I wanted to change for a long time API-wise is to address issue #408. That's technically in the secprofnodestatus
API though.
I'm explicitly not marking as LGTM because I think API graduation patches should have multiple reviewers. But, looks-good-to-me :-)
On Wed, Nov 17, 2021 at 02:44:50AM -0800, Juan Osorio Robles wrote:
@jhrozek would solving #408 affect the API? I'm fine with deferring this graduation until that is solved.
It will not (I actually took the time to carefully look at the code).
But let me fix 408 anyway, it's been open for too long :-)
|
I opened the PR for 408 and it didn't change anything except a label. And because this PR has been open long enough for people to voice their opposition, I'm going to mark it for merging. If I screwed up, you can yell at me tomorrow over video. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhrozek, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Graduate the seccomp profile API. This also changes the imports to not mention the API version any more for easier graduation later on.
Which issue(s) this PR fixes:
None
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?