Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate seccomp profile from v1alpha1 to v1beta1 #674

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind api-change

What this PR does / why we need it:

Graduate the seccomp profile API. This also changes the imports to not mention the API version any more for easier graduation later on.

Which issue(s) this PR fixes:

None

Does this PR have test?

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Graduate seccomp profile API from `v1alpha1` to `v1beta1`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 16, 2021
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Merging #674 (dcbf699) into master (77a3c30) will not change coverage.
The diff coverage is 28.57%.

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   51.67%   51.67%           
=======================================
  Files          31       31           
  Lines        2061     2061           
=======================================
  Hits         1065     1065           
  Misses        943      943           
  Partials       53       53           

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that seccomp in general has been stable enough to promote. And it would make a nice 0.4.0 release highlight. The only thing I wanted to change for a long time API-wise is to address issue #408. That's technically in the secprofnodestatus API though.

I'm explicitly not marking as LGTM because I think API graduation patches should have multiple reviewers. But, looks-good-to-me :-)

@JAORMX
Copy link
Contributor

JAORMX commented Nov 17, 2021

@jhrozek would solving #408 affect the API? I'm fine with deferring this graduation until that is solved.

@jhrozek
Copy link
Contributor

jhrozek commented Nov 17, 2021 via email

@jhrozek
Copy link
Contributor

jhrozek commented Nov 22, 2021

On Wed, Nov 17, 2021 at 02:44:50AM -0800, Juan Osorio Robles wrote: @jhrozek would solving #408 affect the API? I'm fine with deferring this graduation until that is solved.
It will not (I actually took the time to carefully look at the code). But let me fix 408 anyway, it's been open for too long :-)

I opened the PR for 408 and it didn't change anything except a label. And because this PR has been open long enough for people to voice their opposition, I'm going to mark it for merging. If I screwed up, you can yell at me tomorrow over video.

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jhrozek,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6e12fe5 into kubernetes-sigs:master Nov 22, 2021
@saschagrunert saschagrunert deleted the seccomp-v1beta1 branch November 23, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants