Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PV owner reference #123

Merged
merged 1 commit into from Jul 26, 2019

Conversation

@h0tbird
Copy link
Contributor

commented Jul 1, 2019

When a PV is created it is set to be dependent of the Node backing it.
When the Node is deleted the PV is also deleted by the k8s garbage collector.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

Welcome @h0tbird!

It looks like this is your first PR to kubernetes-sigs/sig-storage-local-static-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-storage-local-static-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from cofyc and jsafrane Jul 1, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

Hi @h0tbird. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msau42

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

/ok-to-test

We should consider if there's any use cases for leaving the PVs around, and would any users be depending on this current behavior. If there are such use cases, then this may need to enabled as a new option to not break backwards compatibility.

cc @cofyc @gnufied

@gnufied

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

I can't think of a reason of not doing this. so +1 from me.

@h0tbird

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

/retest

@h0tbird

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

/test pull-sig-storage-local-static-provisioner-e2e-gke

@h0tbird

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

/assign @cofyc

@cofyc

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

add an option for this?

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Jul 10, 2019
@h0tbird

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

/retest

@h0tbird

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

/test pull-sig-storage-local-static-provisioner

@cofyc

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

LGTM

@msau42 What do you think?

Copy link
Contributor

left a comment

For cloud I think this makes sense because local volumes are ephemeral with the Node. For baremetal/onprem I'm more worried there is some scenario we may miss, but since this is opt-in and we also have the Storage Protection feature this seems fine.

pkg/common/common.go Show resolved Hide resolved
@h0tbird

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

/test pull-sig-storage-local-static-provisioner

@h0tbird

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

The test is failing with the error:

The command '/bin/sh -c apt-get update     && apt-get upgrade -y     && clean-install     util-linux     e2fsprogs     bash' returned a non-zero code: 1

Not much I can do about it, I will retry later.

@cofyc

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

/retest

@cofyc

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

Thanks! LGTM. Can you squash the commits a bit?

@h0tbird h0tbird force-pushed the newrelic-forks:owner-reference branch from 74869f0 to 4706ec1 Jul 25, 2019
@h0tbird h0tbird force-pushed the newrelic-forks:owner-reference branch from 4706ec1 to 66123a9 Jul 25, 2019
@h0tbird

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

/test pull-sig-storage-local-static-provisioner

@h0tbird

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

/retest

@cofyc

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 26, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc, h0tbird

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 747ad24 into kubernetes-sigs:master Jul 26, 2019
6 of 7 checks passed
6 of 7 checks passed
tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation h0tbird authorized
Details
pull-sig-storage-local-static-provisioner Job succeeded.
Details
pull-sig-storage-local-static-provisioner-e2e Job succeeded.
Details
pull-sig-storage-local-static-provisioner-e2e-gke Job succeeded.
Details
pull-sig-storage-local-static-provisioner-test Job succeeded.
Details
pull-sig-storage-local-static-provisioner-verify Job succeeded.
Details
@mhenniges mhenniges referenced this pull request Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.