Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notes about using Filesystem on block devices #130

Merged
merged 1 commit into from Feb 5, 2020
Merged

Add notes about using Filesystem on block devices #130

merged 1 commit into from Feb 5, 2020

Conversation

mattymo
Copy link
Contributor

@mattymo mattymo commented Jul 16, 2019 •
edited

Fixes #129

@k8s-ci-robot
Copy link
Contributor

Welcome @mattymo!

It looks like this is your first PR to kubernetes-sigs/sig-storage-local-static-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-storage-local-static-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 16, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 16, 2019
@mattymo
Copy link
Contributor Author

mattymo commented Jul 16, 2019

/assign @msau42

msau42
msau42 reviewed Jul 16, 2019
View reviewed changes
docs/operations.md
$ sudo ln -s /dev/disk/by-id/lvm-pv-uuid-yyTnct-TpUS-U93g-JoFs-6seh-Yy29-Dn6Irf /mnt/disks
```

Additional notes: Your storage class must have VolumeMode set to "Filesystem"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PVC is the one that specifies volumeMode. Can you also add clarify here which provisioner configmap parameters need to be set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be set in the provisioner, the storageclass, and in the pvc for it to work. Otherwise, it appears as a block PV

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no volumeMode field in the StorageClass object. Can you clarify in the doc here exactly which K8s objects and provisioner configmap values need to be set?

docs/operations.md
@@ -154,6 +154,38 @@ Link it into discovery directory:
$ sudo ln -s /dev/disk/by-id/lvm-pv-uuid-yyTnct-TpUS-U93g-JoFs-6seh-Yy29-Dn6Irf /mnt/disks
```

### Link devices into directory to be discovered as Filesystem PVs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the TOC above?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattymo you can generate it with markdown-toc, e.g. markdown-toc --no-firsth1 docs/operations.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding me to do this.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2019
@cofyc
Copy link
Member

cofyc commented Oct 21, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2019
@msau42
Copy link
Contributor

msau42 commented Nov 13, 2019

@mattymo do you still have time to work on this?

@cofyc
Copy link
Member

cofyc commented Feb 5, 2020 •
edited

/lgtm
/approve
I'm going to merge this. We can improve it (TOC, etc.) in a follow-up PR.
@mattymo Thanks for your contribution!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc, mattymo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2d9a734 into kubernetes-sigs:master Feb 5, 2020
@cofyc cofyc mentioned this pull request Feb 5, 2020
Merged
@cofyc cofyc mentioned this pull request Feb 25, 2020
Closed
davidmccormick pushed a commit to davidmccormick/sig-storage-local-static-provisioner that referenced this pull request Mar 31, 2021
@k8s-ci-robot
Merge pull request kubernetes-sigs#130 from mattymo/devices-filesyste…
26ab74b 
…m-doc

Add notes about using Filesystem on block devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofyc cofyc cofyc left review comments

@msau42 msau42 msau42 left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@cofyc cofyc

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation on how to use fs on block mode.
5 participants
@mattymo @k8s-ci-robot @fejta-bot @cofyc @msau42