Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart rework v2 #179

Merged
merged 7 commits into from
Mar 16, 2020
Merged

Helm chart rework v2 #179

merged 7 commits into from
Mar 16, 2020

Conversation

HaveFun83
Copy link
Contributor

@HaveFun83 HaveFun83 commented Feb 27, 2020 •
edited

Did some refactoring on the helm chart to match the helm best practices

  • split deployment files into "single objects"
  • join values from rbac and serviceAccount
  • removed namespace creation. As helm v2 will create one during install and on helm v3 the namespace must already created before install.
  • removed common.configMapName . This will be generated from the release-name
  • removed daemonset.name. This will be generated from the helm release-name
  • removed daemonset.serviceAccount This will be generated from the helm release-name
  • changed metadata.labels
  • rework the Prometheus servicemonitor creation
  • added generation / verify for helm v2 and helm v3

Please have a look. Feedback is welcome
Thanks

@cofyc sorry i opened a new pr as i messed up the old one

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @HaveFun83. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 27, 2020
@HaveFun83
Copy link
Contributor Author

/assign @cofyc

@HaveFun83
Copy link
Contributor Author

@cofyc any news here?

cofyc
cofyc reviewed Mar 2, 2020
View reviewed changes
helm/examples/baremetal-namespace.yaml
@@ -1,10 +0,0 @@
common:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because:

removed namespace creation. As helm v2 will create one during install and on helm v3 the namespace must already created before install.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

cofyc
cofyc reviewed Mar 2, 2020
View reviewed changes
helm/provisioner/values.yaml
@@ -3,17 +3,21 @@
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the format of the new values LGTM, but we should make the new chart backward compatible with old values yaml as possible as we can, e.g.

  • daemonset.name override the name of DaemonSet if present
  • common.configMapName overrides the name of ConfigMap if present
  • common. podSecurityPolicy overrides the rbac.pspEnabled if present
  • etc.

then, people can use the old values file with the new chart and don't worry about any problems during upgrading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do this but it means duplication in the value / chart template files which is not a good approach in my eyes.
Please have look in the helm/Readme.md i added a section about upgrading.
During tests within vagrant i saw no issues during upgrading from old to new chart version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

cofyc
cofyc reviewed Mar 2, 2020
View reviewed changes
hack/lib.sh Show resolved Hide resolved
cofyc
cofyc reviewed Mar 2, 2020
View reviewed changes
hack/verify-generated.sh Outdated Show resolved Hide resolved
@cofyc
Copy link
Member

cofyc commented Mar 16, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 16, 2020
@cofyc
Copy link
Member

cofyc commented Mar 16, 2020

/lgtm
/approve

Great work!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc, HaveFun83

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 73cda4c into kubernetes-sigs:master Mar 16, 2020
@HaveFun83
Copy link
Contributor Author

@cofyc big thanks for your support and review.

@HaveFun83 HaveFun83 deleted the helm-chart-rework-v2 branch March 22, 2020 20:19
davidmccormick pushed a commit to davidmccormick/sig-storage-local-static-provisioner that referenced this pull request Mar 31, 2021
@k8s-ci-robot
Merge pull request kubernetes-sigs#179 from HaveFun83/helm-chart-rewo…
0c30a88 
…rk-v2

Helm chart rework v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofyc cofyc cofyc left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@cofyc cofyc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HaveFun83 @k8s-ci-robot @cofyc