Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip TLS verify on file download #192

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Skip TLS verify on file download #192

merged 1 commit into from
Dec 1, 2021

Conversation

hxietkg
Copy link
Contributor

@hxietkg hxietkg commented Dec 1, 2021

To avoid the issue of "certificate signed by unknown authority"

Reason for PR:

golang-1.16 and ubuntu are used to replace golang:1.16-alpine and apline, they will check CA during file download, just skip the check.

Issue Fixed:

Issue #

Requirements

  • Sqaush commits
  • Documentation
  • Tests

Notes:

@hxietkg
Skip TLS verify on file download
241d683 
To avoid the issue of "certificate signed by unknown authority"
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hxietkg
To complete the pull request process, please assign jsturtevant after the PR has been reviewed.
You can assign the PR to them by writing /assign @jsturtevant in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2021
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 1, 2021
@hxietkg
Copy link
Contributor Author

hxietkg commented Dec 1, 2021

please close this PR, duplicated from #191

@jayunit100 jayunit100 merged commit b9d96fc into kubernetes-sigs:master Dec 1, 2021
@jayunit100
Copy link
Contributor

i merged it, no prob i closed mine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebroy ddebroy Awaiting requested review from ddebroy

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hxietkg @k8s-ci-robot @jayunit100