Scripts update to make them usable with hostprocess model #248
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
github-actions
bot
added
the
tide/merge-method-squash
k8s-ci-robot
added
size/M
a4099181
force-pushed
the
wip/scripts-update
branch
from
dc34af0
to
8b56114
Compare
k8s-ci-robot
added
the
needs-rebase
a4099181
force-pushed
the
wip/scripts-update
branch
from
8b56114
to
42980df
Compare
k8s-ci-robot
added
size/M
a4099181
force-pushed
the
wip/scripts-update
branch
from
42980df
to
bfd95c2
Compare
k8s-ci-robot
added
size/L
|
/assign |
|
The behavior of volume mounts changes depending on if you are using containerd Can we update all the references to default to https://github.com/containerd/containerd/releases/tag/v1.7.0-beta.1 instead of v1.6.8 (until v1.7.0 releases)? |
| HelpMessage = "Name of network adapter to use when configuring basic nat network", | ||
| ParameterSetName = "kubeadm" | ||
| )] | ||
| [string] $netAdapterName = "Ethernet", |
There was a problem hiding this comment.
I think we can drop the $netAdapterName param since this script no longer creates a nat network (removed with #254 b/c it was causing lots of issues)
There was a problem hiding this comment.
Yes, now it is unused parameter. Should we take care of the backward compatibility? If not, then we can do some more cleanups in both scripts. If so, these scripts will not fit kubeadm folder no longer. Maybe better/cleaner version of the scripts should be made in host-process folder. But there is a couple of PR's which makes changes to them right now. It is not a good time, I think.
Currently, after #254, UseHostProcess parameter is only for containerd version assert purpose. It may not be necessary at all.
I am not convinced to update referenced containerd version in this PR.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: a4099181 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It seems that Install-Container.ps1 and PrepareNode.ps1 may be useful to build Windows node with HostProcess containers and k8s 1.25.3 at least. But some changes are needed, becasue some code does not cooperate. This commit is a propose to leave current code unchanged for backward compatibility and introduce UseHostProcess parameter to handle code not needed to support HostProcess containers where are engaged. Additionally it offers SuppressHints parameter to have an option to omit on demand some help messages. Omitted code depends on git tool installed. It may be an optimization for automated node provisioning (eg. vagrant) and saves some time wasted for git install and repository cloning.
a4099181
force-pushed
the
wip/scripts-update
branch
from
bfd95c2
to
c564814
Compare
|
Thanks for your updates here. We discussed at sig-windows community meeting a couple weeks ago and decided it would be easier to maintain long term just the HostProcess parts in the scripts going forward (#262). I am going to close this PR since the changes were made in #262. Please open issue/pr if those changes aren't working with Hostprocess. Thanks again for your interest here. /close |
Reason for PR:
It seems that
Install-Container.ps1andPrepareNode.ps1may be useful to build a Windows node with HostProcess containers and k8s 1.25.3 at least. But some changes are needed because some code does not cooperate. This commit is a proposal to leave the current code unchanged for backward compatibility and introduce the UseHostProcess parameter to handle code not needed to support HostProcess containers where are engaged.Requirements
Notes:
There are also changes beyond the main reason. When the UseHostProcess flag is present, the script makes asserts on Kubernetes and ContainerD versions to announce incompatibilities. Another improvement is to not have a choice of container runtime when HostProcess is in use.
Additionally, it offers the SuppressHints parameter to have the option to omit on demand some help messages. Omitted code depends on the git tool installed. It may be an optimization for automated node provisioning (eg. vagrant) and saves some time wasted for git install and repository cloning.