-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanation for parameter $CALICO_VERSION #312
Conversation
|
Welcome @kkbruce! |
Co-authored-by: James Sturtevant <jsturtevant@gmail.com>
Thank you for your review. Your meaning is more precise than what I expressed. |
Thank you for taking the time to improve the docs! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant, kkbruce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for PR:
The $CALICO_VERSION parameter does not refer to the same version value in the context, which can cause errors after the script runs. Add an explanation to avoid errors.
Issue Fixed:
Issue #310
Requirements
Notes: