Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare repository to push container images to community owned container registries #9

Merged
merged 3 commits into from Jul 5, 2022

Conversation

leonardpahlke
Copy link
Member

Signed-off-by: leonardpahlke leonard.pahlke@googlemail.com

Next PR (2/3) to push testgrid-json-exporter container images to kubernetes owned container registries :)

This PR adds

  • codebuild.yaml configuration file
  • minimal Makefile (with one command to run a script)
  • image.sh script to build and push container images to GCR

I took k-sigs/security-profiles-operator/cloudbuild.yaml & k-sigs/security-profiles-operator/image-cross.sh as a reference

See tracking issue: #1

/cc @saschagrunert

@saschagrunert I am uncertain about the name of the GCR step to make the container images (Line 8 codebuild.yaml. Currently its gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90 copied from kubernetes-sigs/security-profiles-operator, should this get changed?

Signed-off-by: leonardpahlke <leonard.pahlke@googlemail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2022
Signed-off-by: leonardpahlke <leonard.pahlke@googlemail.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2022
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to use the latest image, otherwise LGTM 👍

codebuild.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2022
Co-authored-by: Sascha Grunert <sgrunert@redhat.com>
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leonardpahlke, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit c4cc7a3 into kubernetes-sigs:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants