Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test case file and folder structure #83

Conversation

tzifudzi
Copy link
Contributor

@tzifudzi tzifudzi commented Aug 1, 2023

What type of PR is this?

New feature

What this PR does / why we need it:

Helps organize the test cases such that each Ops Readiness Spec is in its own folder. This should make the test cases more easier to read through, and easier to maintain. Accompanying README.md will also assist with any additional information regarding the specification.

Previous structure

  • testcases.yaml

New structure

  • specifications/
    • core-concurrent/
      • README.md
      • spec.yaml

Which issue(s) this PR fixes:

Testing

Ran automated tests in the project with all passing. Also ran manual tests against a local cluster to ensure no breaking changes have been introduced.

Sample output from test run ./op-readiness --provider=aws --kubeconfig=$KUBECONFIG --dry-run=true --category=Core.Network

2023-08-01T09:05:56-07:00       INFO    Discovered 9 test files for Windows Ops Readiness specifications Core.Concurrent, Core.Network, Core.Scheduling, Core.Storage, Extend.ActiveDirectory, Extend.HostProcess, Extend.Network, Extend.NetworkPolicy, Extend.Worker
2023-08-01T09:05:56-07:00       INFO    [OpReadinessTests] Skipping Ops Readiness Tests for Core.Concurrent because specification was not specified in category filter
...
2023-08-01T09:05:56-07:00       INFO    [OpReadinessTests] 1 / 1 Specifications - Running 10 Test(s) for Ops Readiness specification: Core.Network
2023-08-01T09:05:56-07:00       INFO    [Core.Network] 1 / 10 Tests - Running Operational Readiness test: Ability to access Windows container IP by pod IP
...
2023-08-01T09:06:10-07:00       INFO    Ran 1 of 6965 Specs in 0.012 seconds
2023-08-01T09:06:10-07:00       INFO    SUCCESS! -- 0 Passed | 0 Failed | 0 Pending | 6964 Skipped
2023-08-01T09:06:10-07:00       INFO    [OpReadinessTests] Completed running Ops Readiness tests

Additional notes

All test cases have been migrated to new structure as is from the main branch with no further alterations e.g. if was commented I left it commented

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 1, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @tzifudzi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 1, 2023
@tzifudzi tzifudzi force-pushed the feature/change-testcases-structure branch from 7d692f8 to b1dabba Compare August 1, 2023 03:36
@tzifudzi tzifudzi marked this pull request as ready for review August 1, 2023 16:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2023
@knabben
Copy link
Member

knabben commented Aug 2, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knabben, tzifudzi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4cb47d6 into kubernetes-sigs:main Aug 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants