-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test case file and folder structure #83
Refactor test case file and folder structure #83
Conversation
Hi @tzifudzi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7d692f8
to
b1dabba
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knabben, tzifudzi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
New feature
What this PR does / why we need it:
Helps organize the test cases such that each Ops Readiness Spec is in its own folder. This should make the test cases more easier to read through, and easier to maintain. Accompanying README.md will also assist with any additional information regarding the specification.
Previous structure
New structure
Which issue(s) this PR fixes:
Testing
Ran automated tests in the project with all passing. Also ran manual tests against a local cluster to ensure no breaking changes have been introduced.
Sample output from test run
./op-readiness --provider=aws --kubeconfig=$KUBECONFIG --dry-run=true --category=Core.Network
Additional notes
All test cases have been migrated to new structure as is from the main branch with no further alterations e.g. if was commented I left it commented