Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstreams: add gitlab as upstream option #22

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 4, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add a GitLab as a new upstream option to be used to validate and check dependencies

It supports both the public GitLab and also a private (self-hosted) GitLab

The behavior is very similar to the GitHub one.
You will need to set the environment variable GITLAB_TOKEN or GITLAB_PRIVATE_TOKEN

a live run 馃槃

$ ./zeitgeist validate  --remote
Update available for dependency gitlabtest: 3.10.0 (current: 2.5.0)
Update available for dependency internal: 1.2.0 (current: 0.5.0)

using this sample dependencies.yaml

dependencies:
- name: gitlabtest
  version: 2.5.0
  upstream:
    flavour: gitlab
    url: harbottle/puppet-mattermost
- name: internal
  version: 0.5.0
  upstream:
    flavour: gitlab
    server: https://gitlab.eng.company.com/
    url: cpanatojr/testing-release-api

This is an initial, there more things to add, like more tests

/assign @justaugustus @saschagrunert @hasheddan

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

upstreams: add gitlab as upstream option

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2021
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 4, 2021
@Pluies
Copy link
Contributor

Pluies commented Feb 4, 2021

@cpanato woohoo, that sounds great!! I'll review the code asap, looking forward to it! :)

@justaugustus justaugustus added this to In progress in Release Engineering (k-sigs) via automation Feb 4, 2021
@justaugustus
Copy link
Member

This is great work, @cpanato!
Let's iterate on anything we need to, since it looks like you've already started working on testing this. :)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit bb1e2ae into kubernetes-sigs:master Feb 5, 2021
Release Engineering (k-sigs) automation moved this from In progress to Done Feb 5, 2021
@cpanato cpanato deleted the add-gitlab branch February 6, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Development

Successfully merging this pull request may close these issues.

None yet

6 participants