Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pluralize package names when possible and improve debugs #39

Merged
merged 3 commits into from Mar 11, 2021
Merged

Don't pluralize package names when possible and improve debugs #39

merged 3 commits into from Mar 11, 2021

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Don't pluralize package names when possible
  • upstream: Don't stutter exported types
  • Improve debug message formats

/assign @cpanato @wilsonehusin @ykakarap

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- A few packages have been renamed:
  - `dependencies` --> `dependency`
  - `upstreams` --> `upstream`

@justaugustus
Don't pluralize package names when possible
885734e 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
upstream: Don't stutter exported types
5bdc970 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
Improve debug message formats
56e8ec8 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus justaugustus added this to In progress in Release Engineering (k-sigs) via automation Mar 11, 2021
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 11, 2021
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2021
@justaugustus justaugustus changed the title Cleanup Don't pluralize package names when possible and improve debugs Mar 11, 2021
cpanato
cpanato approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks for that, much cleaner such wow!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ae0f582 into kubernetes-sigs:master Mar 11, 2021
Release Engineering (k-sigs) automation moved this from In progress to Done Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@hasheddan hasheddan Awaiting requested review from hasheddan

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@cpanato cpanato

@wilsonehusin wilsonehusin

@ykakarap ykakarap

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Release Engineering (k-sigs)
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@justaugustus @k8s-ci-robot @cpanato @wilsonehusin @ykakarap