Adding prom metrics handler #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is really just a hammer to add in prom metrics exposed on :8080/metrics. As you see it wraps every endpoint. Additionally, it does not attempt to match on the actual pattern of the URL and instead uses the URL. This in reality is not a good practice as Prometheus does not scale well with super high cardinality data
|
Love it! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prep for your TGIK demo, if you wanted to have something simple in KUARD to expose metrics with... This is really just a hammer to add in prom metrics exposed on :8080/metrics. As you see
it wraps every endpoint.
Additionally, it does not attempt to match on the actual pattern of the URL and instead
uses the URL. This in reality is not a good practice as Prometheus does not scale well
with super high cardinality data.
Essentially just plagiarizing content from https://youtu.be/TJLpYXbnfQ4?list=PLxlCI-LN9VxoOd4bPaWytkfgHo7qyregA as I found it very useful