Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceQuota: Hard and Used are not ResourceList #31

Closed
AliMohammadiSoumee opened this issue Jul 21, 2020 · 6 comments
Closed

ResourceQuota: Hard and Used are not ResourceList #31

AliMohammadiSoumee opened this issue Jul 21, 2020 · 6 comments

Comments

@AliMohammadiSoumee
Copy link

When I was using ResourceQuotaStatus.Hard, I found a mistake. Hard and Used are ResourceList, but actually they are not.

When you define Hard as a ResourceList, I can call methods of ResourceList on it, So I can call ResourceQuota.Status.Hard.CPU() for example, but it returns nothing because Hard contains Limits and Requests like ResourceRequirements type.

I know you define some constants for getting requests and limits from the Hard's ResourceList map(like ResourceRequestsCPU).

Can you explain why you didn't use ResourceRequirements as the type of the Hard or Used?
Can I fix it by changing types to ResourceRequirements?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 19, 2020
@AliMohammadiSoumee
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2021
@AliMohammadiSoumee
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2021
@SergeyKanzhelev
Copy link
Member

you may have better luck filing issue on the main kubernetes repository. This is just a mirror repo and it is not monitored for issues. See https://github.com/kubernetes/api#things-you-should-not-do

/close

@k8s-ci-robot
Copy link

@SergeyKanzhelev: Closing this issue.

In response to this:

you may have better luck filing issue on the main kubernetes repository. This is just a mirror repo and it is not monitored for issues. See https://github.com/kubernetes/api#things-you-should-not-do

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants