Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PrepareForDelete to RESTGracefulDeleteStrategy #21

Closed
staebler opened this issue Oct 20, 2017 · 5 comments
Closed

Add PrepareForDelete to RESTGracefulDeleteStrategy #21

staebler opened this issue Oct 20, 2017 · 5 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@staebler
Copy link
Contributor

There is a desire in https://github.com/kubernetes-incubator/service-catalog to have a PrepareForDelete function in the RESTGracefulDeleteStrategy interface similar to PrepareForCreate and PrepareForUpdate functions in the RESTCreateStrategy and RESTUpdateStrategy interfaces. When ServiceInstance and ServiceBinding resources are deleted in service-catalog, the user that requested the delete is stored in the resource to be sent to the broker. Currently, service-catalog uses the CheckGracefulDelete function to get the user from the context to add it to the resource. That does not seem like an appropriate use of that function.
@deads2k
Copy link
Collaborator

deads2k commented Oct 25, 2017

We get the object in storage to decide whether it is immediately deleted already. I don't object to adding an injection point, but without a finalizer the object could deleted straight away.

@kubernetes/sig-api-machinery-feature-requests

@staebler
Copy link
Contributor Author

Immediate deletion is not an issue as far as service-catalog is concerned. We add a finalizer. We would not be using the injection point as a means of postponing deletion.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 22, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@deads2k @k8s-ci-robot @staebler @fejta-bot