-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DecisionNoOpinion when denied field is missing #50
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Webhook authorizer checks
denied
field of SubjectAccessReviewStatus to make a decision if access is denied. According to SubjectAccessReviewStatus docs fielddenied
is optional. On the other hand the same doc states that "If both allowed is false and denied is false, then the authorizer has no opinion on whether to authorize the action". It makes perfect sense when both fields are set, but whendenied
is missing bool's default value kicks in and the result is the same. This is example response from api server:Status clearly states that access is denied, but webhook authorizer would return DecisionNoOpinion in this scenario. I'm using k8s version 1.10.
The text was updated successfully, but these errors were encountered: