Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logging calls(azure_container_service_pool.go) #1253

Merged
merged 1 commit into from Sep 18, 2018
Merged

fix logging calls(azure_container_service_pool.go) #1253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions cluster-autoscaler/cloudprovider/azure/azure_container_service_pool.go
View file
Open in desktop
Expand Up @@ -122,7 +122,7 @@ func (agentPool *ContainerServiceAgentPool) getAKSNodeCount() (count int, err er
agentPool.resourceGroup,
agentPool.clusterName)
if err != nil {
glog.Error("Failed to get AKS cluster (name:%q): %v", agentPool.clusterName, err)
glog.Errorf("Failed to get AKS cluster (name:%q): %v", agentPool.clusterName, err)
return -1, err
}

Expand All @@ -147,7 +147,7 @@ func (agentPool *ContainerServiceAgentPool) getACSNodeCount() (count int, err er
agentPool.resourceGroup,
agentPool.clusterName)
if err != nil {
glog.Error("Failed to get ACS cluster (name:%q): %v", agentPool.clusterName, err)
glog.Errorf("Failed to get ACS cluster (name:%q): %v", agentPool.clusterName, err)
return -1, err
}

Expand All @@ -172,7 +172,7 @@ func (agentPool *ContainerServiceAgentPool) setAKSNodeCount(count int) error {
agentPool.resourceGroup,
agentPool.clusterName)
if err != nil {
glog.Error("Failed to get AKS cluster (name:%q): %v", agentPool.clusterName, err)
glog.Errorf("Failed to get AKS cluster (name:%q): %v", agentPool.clusterName, err)
return err
}

Expand All @@ -190,7 +190,7 @@ func (agentPool *ContainerServiceAgentPool) setAKSNodeCount(count int) error {
future, err := aksClient.CreateOrUpdate(updateCtx, agentPool.resourceGroup,
agentPool.clusterName, managedCluster)
if err != nil {
glog.Error("Failed to update AKS cluster (%q): %v", agentPool.clusterName, err)
glog.Errorf("Failed to update AKS cluster (%q): %v", agentPool.clusterName, err)
return err
}
return future.WaitForCompletion(updateCtx, aksClient.Client)
Expand All @@ -205,7 +205,7 @@ func (agentPool *ContainerServiceAgentPool) setACSNodeCount(count int) error {
agentPool.resourceGroup,
agentPool.clusterName)
if err != nil {
glog.Error("Failed to get ACS cluster (name:%q): %v", agentPool.clusterName, err)
glog.Errorf("Failed to get ACS cluster (name:%q): %v", agentPool.clusterName, err)
return err
}

Expand All @@ -223,7 +223,7 @@ func (agentPool *ContainerServiceAgentPool) setACSNodeCount(count int) error {
future, err := acsClient.CreateOrUpdate(updateCtx, agentPool.resourceGroup,
agentPool.clusterName, acsCluster)
if err != nil {
glog.Error("Failed to update ACS cluster (%q): %v", agentPool.clusterName, err)
glog.Errorf("Failed to update ACS cluster (%q): %v", agentPool.clusterName, err)
return err
}
return future.WaitForCompletion(updateCtx, acsClient.Client)
Expand Down Expand Up @@ -394,7 +394,7 @@ func (agentPool *ContainerServiceAgentPool) GetNodes() ([]string, error) {
defer cancel()
vmList, err := agentPool.manager.azClient.virtualMachinesClient.List(ctx, agentPool.nodeResourceGroup)
if err != nil {
glog.Error("Error", err)
glog.Errorf("Azure client list vm error : %v", err)
return nil, err
}
var nodeArray []string
Expand Down