Fix some typos in comment #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JoeWrightss
commented
Jan 12, 2019
JoeWrightss
commented
- "scheduable" to "schedulable".
- "SynchornizedBeforeSuite" to "SynchronizedBeforeSuite".
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
k8s-ci-robot
added
size/XS
|
/assign @bskiba |
bskiba
reviewed
Jan 14, 2019
| @@ -142,4 +142,4 @@ If you'd like to scale node groups from 0, an `autoscaling:DescribeLaunchConfigu | |||
| - Cluster autoscaler is not zone aware (for now), so if you wish to span multiple availability zones in your autoscaling groups beware that cluster autoscaler will not evenly distribute them. For more information, see https://github.com/kubernetes/contrib/pull/1552#discussion_r75532949. | |||
| - By default, cluster autoscaler will not terminate nodes running pods in the kube-system namespace. You can override this default behaviour by passing in the `--skip-nodes-with-system-pods=false` flag. | |||
| - By default, cluster autoscaler will wait 10 minutes between scale down operations, you can adjust this using the `--scale-down-delay-after-add`, `--scale-down-delay-after-delete`, and `--scale-down-delay-after-failure` flag. E.g. `--scale-down-delay-after-add=5m` to decrease the scale down delay to 5 minutes after a node has been added. | |||
| - If you're running multiple ASGs, the `--expander` flag supports three options: `random`, `most-pods` and `least-waste`. `random` will expand a random ASG on scale up. `most-pods` will scale up the ASG that will scheduable the most amount of pods. `least-waste` will expand the ASG that will waste the least amount of CPU/MEM resources. In the event of a tie, cluster autoscaler will fall back to `random`. | |||
| - If you're running multiple ASGs, the `--expander` flag supports three options: `random`, `most-pods` and `least-waste`. `random` will expand a random ASG on scale up. `most-pods` will scale up the ASG that will schedulable the most amount of pods. `least-waste` will expand the ASG that will waste the least amount of CPU/MEM resources. In the event of a tie, cluster autoscaler will fall back to `random`. | |||
There was a problem hiding this comment.
most-podswill scale up the ASG that will schedulable the most amount of pods
This sentence doesn' t make sense. Can you fix it while you're at it?
There was a problem hiding this comment.
Thank you for guiding me, @bskiba🐯.
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
|
Thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bskiba, JoeWrightss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
yaroslava-serdiuk
pushed a commit
to yaroslava-serdiuk/autoscaler
that referenced
this pull request
Feb 22, 2024
* [jobset] Add prebuilt workload support. * Review Remarks. * Review Remarks
gandhipr
added a commit
to gandhipr/autoscaler
that referenced
this pull request
Apr 2, 2024
add missing line in 1.23+ CA versions related old change - https://dev.azure.com/AzureContainerUpstream/Kubernetes/_git/autoscaler/commit/9308ae62d84a1cac564011db2ab3b4b570efecef?refName=refs%2Fheads%2Fcluster-autoscaler-release-1.21 Looks like this line was skipped in 1.23 CA + version Related work items: kubernetes#1575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.