Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add api-approved label to the Vertical Pod Autoscaler API #3080

Merged
merged 1 commit into from Apr 27, 2020
Merged

Add api-approved label to the Vertical Pod Autoscaler API #3080

merged 1 commit into from Apr 27, 2020

Conversation

bskiba
Copy link
Member

@bskiba bskiba commented Apr 22, 2020

Resources are part of verticalpodautoscalers.autoscaling.k8s.io

  • VerticalPodAutoscaler is an api resource for configuring vertical autoscaling for pods.
  • VerticalPodAutoscalerCheckpoint is an API resource used internally by the Vertical Pod Autoscaler to store its additional state.

The API was discussed and approved in kubernetes/kubernetes#63797
The design itself was discussed and approved in kubernetes/community#338

Fixes #3069

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2020
@bskiba
Copy link
Member Author

bskiba commented Apr 22, 2020

@mwielgus @gjtempleton Can one of you approve as SIG-Autoscaling leads?

@bskiba
Copy link
Member Author

bskiba commented Apr 22, 2020 •
edited

Getting following conditions on the CRD from this PR

 Conditions:
    Last Transition Time:  2020-04-22T15:36:55Z
    Message:               approved in https://github.com/kubernetes/kubernetes/pull/63797
    Reason:                ApprovedAnnotation
    Status:                True
    Type:                  KubernetesAPIApprovalPolicyConformant

@gjtempleton
Copy link
Member

This looks good to me. Won't work with prow, but /approve

@gjtempleton
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2020
joelsmith added a commit to joelsmith/vertical-pod-autoscaler-operator that referenced this pull request Apr 24, 2020
@joelsmith
Add api-approved annotation
72209b0 
See kubernetes/autoscaler#3080
@joelsmith joelsmith mentioned this pull request Apr 24, 2020
Merged
mwielgus
mwielgus approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 51eb724 into kubernetes:master Apr 27, 2020
@bskiba
Copy link
Member Author

bskiba commented Apr 27, 2020

Thanks @gjtempleton and @mwielgus

jingxu97 pushed a commit to jingxu97/kubernetes that referenced this pull request Mar 2, 2021
@bskiba
Add api-approved label to the Vertical Pod Autoscaler API
f546ff8 
Approved in OSS with kubernetes/autoscaler#3080

Change-Id: Ia97850495f30585ae5f8e7afc9d7510c7099a3e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@jbartosik jbartosik Awaiting requested review from jbartosik

@krzysied krzysied Awaiting requested review from krzysied

Assignees

@gjtempleton gjtempleton

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vpa and vpacheckpoint CRDs have KubernetesAPIApprovalPolicyConformant condition from MissingAnnotation
4 participants
@bskiba @gjtempleton @k8s-ci-robot @mwielgus