Exoscale cloud provider overhaul

[falzm]

This change refactors the exoscale cloud provider to support both
plain Instance Pools and SKS Nodepools scaling.

[k8s-ci-robot]

Welcome @falzm!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[falzm]

@aleksandra-malinowska @feiskyer do I need to do something to have this PR reviewed?

[falzm]

@aleksandra-malinowska @feiskyer can I have eyes on this PR please? 🙏

[falzm]

@aleksandra-malinowska @feiskyer can I have eyes on this PR please? 🙏

[falzm]

@aleksandra-malinowska @feiskyer can I have eyes on this PR please? 🙏

[PhilippeChepy]

@mwielgus, @MaciekPytel, @bskiba, @gjtempleton, why this PR isn't reviewed ? It's very useful and looks like to be well done work!

[gjtempleton]

Hey @PhilippeChepy, the @k8s-ci-robot comments document the process for PRs, including this stanza:

This pull-request has been approved by: falzm
To complete the pull request process, please assign feiskyer after the PR has been reviewed.
You can assign the PR to them by writing /assign @feiskyer in a comment when ready.

For my part I generally only monitor PRs I've been assigned to at this point, I know some others follow the same workflow.

I have to say that as this appears to be a wholesale change to a CloudProvider where I have no experience, I wouldn't be comfortable reviewing it, and we should be looking to find owners for the Exoscale Cloud Provider, to enable you to take ownership of the code for this CloudProvider implementation, and only need wider approval for changes which touch code outside of this.

@falzm I'm guessing from your comments in the original PR #3470 that you worked with @pierre-emmanuelJ at the time of implementation? Are both of you willing to take on ownership for this implementation (i.e. the contents of the cloudprovider/exoscale directory)?

[PhilippeChepy]

Hi @gjtempleton, thank you for your answer. Please, can you can set ownership of this provider code to:

• @pierre-emmanuelJ
• @7fELF
• @PhilippeChepy

[mwielgus]

/lgtm
/approve

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[gjtempleton]

@falzm It looks like the commit's no longer linking to your Github user, can you update the commit to link it so the CLA check passes?

[falzm]

@falzm It looks like the commit's no longer linking to your Github user, can you update the commit to link it so the CLA check passes?

@PhilippeChepy @7fELF one of you should probably sign off the CLA on behalf of Exoscale at this point, since I'm no longer part of the company. It'd be best if one of you re-authored the commit/PR.

[llambiel]

@PhilippeChepy @7fELF may I ask you to proceed as suggested by @falzm

I'll have a look at the CLA

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: 7fELF / name: Antoine Baudrand (26ea3de)

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: 7fELF / name: Antoine Baudrand (e66e545, a63f9bd)
• ✅ login: dramaturg / name: Sebastian Krohn (bf89632)

[mwielgus]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: falzm, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [mwielgus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment