Adding support for Debugging Snapshot #4552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
jayantjain93
force-pushed
the
debugging-snapshot
branch
3 times, most recently
from
035e301
to
7801d73
Compare
x13n
requested changes
Dec 22, 2021
cluster-autoscaler/debuggingsnapshot/debugging_snapshot_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/debuggingsnapshot/debugging_snapshot_test.go
Outdated
Show resolved
Hide resolved
jayantjain93
force-pushed
the
debugging-snapshot
branch
from
7801d73
to
d89bdfb
Compare
x13n
reviewed
Dec 23, 2021
x13n
requested changes
Dec 23, 2021
jayantjain93
force-pushed
the
debugging-snapshot
branch
3 times, most recently
from
e261d4c
to
a8a6013
Compare
x13n
reviewed
Dec 29, 2021
jayantjain93
force-pushed
the
debugging-snapshot
branch
3 times, most recently
from
24d3a71
to
87d850f
Compare
jayantjain93
force-pushed
the
debugging-snapshot
branch
from
87d850f
to
729038f
Compare
x13n
reviewed
Dec 30, 2021
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jayantjain93, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
Cluster-Autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces a new Debugging Tool, which would make it easier to analyse larger clusters.
Fixes #4346
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: