Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename packet to equinix metal #4580

Merged
merged 3 commits into from Jan 13, 2022
Merged

Rename packet to equinix metal #4580

merged 3 commits into from Jan 13, 2022

Conversation

cprivitere
Copy link
Member

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This PR aims to rename non-code related instances of "Packet" to "Equinix Metal" in order to respect the rename of Packet to Equinix Metal.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 5, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @cprivite!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 5, 2022
@cprivitere cprivitere closed this Jan 5, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2022
@cprivitere cprivitere reopened this Jan 5, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2022
Update example facility and machine plans to current versions.
8f8d071 
Signed-off-by: Chris Privitere <cprivite@users.noreply.github.com>
@displague
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 5, 2022
Add note to readme about the rename of Packet.
c4e1aa2 
Signed-off-by: Chris Privitere <cprivite@users.noreply.github.com>
@displague
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2022
@cprivitere
Copy link
Member Author

/assign @detiber
/assign @towca
Pinging @detiber and @towca for approval.

@cprivitere
Copy link
Member Author

/assign @feiskyer

@detiber
Copy link
Member

detiber commented Jan 12, 2022

/lgtm
/approve

mwielgus
mwielgus approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cprivite, detiber, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit f5de590 into kubernetes:master Jan 13, 2022
@cprivitere cprivitere deleted the Rename_Packet_to_Equinix_Metal branch January 13, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@detiber detiber Awaiting requested review from detiber

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@displague displague

@feiskyer feiskyer

@detiber detiber

@mwielgus mwielgus

@towca towca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cprivitere @k8s-ci-robot @displague @detiber @mwielgus @jbartosik @feiskyer @towca