Allow colon in AWS ASG autodiscovery tag keys

[thecubed]

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR allows the use of colon (:) in AWS ASG autodiscovery tag keys.

Our cluster ASGs are tagged like <namespace>:cluster = <clustername> and <namespace>:nodegroup = <nodegroup>.

The existing code for tag-based autodiscovery would attempt to further split the tag, and this has been fixed to limit the amount of splitting that is done.

We have ensured the tests pass and updated the documentation to demonstrate that the ASG tag discovery code supports tag values as well.

Does this PR introduce a user-facing change?

Added support for colon (`:`) in the AWS ASG discovery tag keys

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Tyler Montgomery (5cb7a2c)

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @thecubed!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[thecubed]

Just signed the CLA, let's see if this gets my cncf-cla: no badge of shame removed :)

/check-cla

[thecubed]

Hm, seems like the cla/linuxfoundation bot hasn't picked up that I've signed the CLA. Am I missing something?

[gjtempleton]

@thecubed It seems this is likely due to the switchover currently ongoing between the old CLA system and the new EasyCLA system. Can I ask how you signed the CLA?

[gjtempleton]

/area provider/aws

[thecubed]

@gjtempleton Ah, I signed the CLA using the EasyCLA system. Thanks for looking into this!

[gjtempleton]

I know it's a pain, but can you also sign the old system for now (the planned switchover to EasyCLA is the 5th of February which should switch over which check is the blocking one to EasyCLA) and see if that resolves it?

[thecubed]

/check-cla

[thecubed]

@gjtempleton Thanks for the help! Looks like it's sorted now.

[gjtempleton]

Awesome, thanks for that, and more importantly, thanks for the PR!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, thecubed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/cloudprovider/aws/OWNERS [gjtempleton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment