Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental updates and improvements to the OCI (Instance-Pool) cloud provider #4769

Merged

Conversation

jlamillan
Copy link
Contributor

Which component this PR applies to?

cluster-autoscaler (OCI provider code)

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

This PR adds a number of incremental updates and other improvements to the OCI (Instance-Pool) cloud provider after after running the initial version in production for several weeks including:

  • dynamic timeout adjustment logic of provider operations based on scale size, lack of progress, etc.
  • support handling paginated API responses from provider
  • support for taking advantage of optional instance pool and instance ID labels on nodes
  • support for retrieving OCI Instance-Pool shape information from cache
  • updated Docker image coordinates in example manifests

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I am the original author of the provider code in question and listed in the OWNERS file (although I am temporarily commented out until I complete the Kubernetes Community Membership process).

Does this PR introduce a user-facing change?

Incremental updates and improvements. 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2022
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlamillan, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4e3b41c into kubernetes:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants