Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added replicas count for daemonsets to prevent massive pod eviction #4978

Merged
merged 1 commit into from Oct 12, 2022
Merged

added replicas count for daemonsets to prevent massive pod eviction #4978

merged 1 commit into from Oct 12, 2022

Conversation

RomanenkoDenys
Copy link
Contributor

@RomanenkoDenys RomanenkoDenys commented Jun 17, 2022 •
edited

Which component this PR applies to?

vertical-pod-autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds ability to count "replicas" in daemonsets, to prevent massive one-time pod restart in daemonsets.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added support for counting replicas in deamonsets to limit how fast VPA evicts them.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 17, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 17, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: RomanenkoDenys / name: Denys Romanenko (6e9527f)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 17, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @RomanenkoDenys!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 17, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 17, 2022
@RomanenkoDenys RomanenkoDenys mentioned this pull request Jun 17, 2022
Merged
@RomanenkoDenys
Copy link
Contributor Author

/assign @krzysied

@nabokihms
Copy link
Member

Hello, @krzysied @jbartosik. What can we do to move this PR further? It seems stuck without comments, and it is unceratin what to do next. We will appreciate any instructions.

jbartosik
jbartosik requested changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some small comments for code.

From description of the PR it sounds like there will be an user-visible change to behavior of VPA with regards to DaemonSets.

Can you give an example of situation where this improves VPAs behavior? (it might be worth adding a e2e test for this).

vertical-pod-autoscaler/pkg/updater/eviction/pods_eviction_restriction.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/updater/eviction/pods_eviction_restriction_test.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/updater/eviction/pods_eviction_restriction_test.go Outdated Show resolved Hide resolved
@RomanenkoDenys RomanenkoDenys requested review from jbartosik and removed request for krzysied September 29, 2022 13:43
@jbartosik
Copy link
Collaborator

Hi, I see that you addressed my comments for small code clean ups.

Could you:

  1. Squash commits in this PR and
  2. Add a release note; In "Does this PR introduce a user-facing change?" put something like "added support for counting replicas in deamonsets to limit how fast VPA evicts them"?

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2022
@RomanenkoDenys
added replicas count for daemonsets to prevent massive pod eviction
2870e1e 
Signed-off-by: Denis Romanenko <denis.romanenko@flant.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 11, 2022
@RomanenkoDenys
Copy link
Contributor Author

Hi, I see that you addressed my comments for small code clean ups.

Could you:

  1. Squash commits in this PR and
  2. Add a release note; In "Does this PR introduce a user-facing change?" put something like "added support for counting replicas in deamonsets to limit how fast VPA evicts them"?

Hi, @jbartosik. I did what you asked, thanks for the reply!

jbartosik
jbartosik approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, RomanenkoDenys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8ad8cd7 into kubernetes:master Oct 12, 2022
navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
@k8s-ci-robot
Merge pull request kubernetes#4978 from RomanenkoDenys/daemonset-coun…
a651a63 
…t-replicas

added replicas count for daemonsets to prevent massive pod eviction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbartosik jbartosik jbartosik approved these changes

Assignees

@jbartosik jbartosik

@krzysied krzysied

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RomanenkoDenys @k8s-ci-robot @nabokihms @jbartosik @krzysied