Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for AWS inf2 instance types #5673

Merged

Conversation

mbdebian
Copy link

Cherry pick from master adding support for the AWS Inferentia 2 instance types targetting branch 1.24

What type of PR is this?
/kind feature

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5626

Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 11, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @mbdebian!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 11, 2023
@ff-apple
Copy link
Contributor

ff-apple commented Apr 14, 2023

+1 👍

Adding @gjtempleton here as already familiar with the change as was the reviewer of PR #5529

FYI: @mmcclean-aws

@ff-apple
Copy link
Contributor

ff-apple commented May 2, 2023

@feiskyer @Jeffwan can you please take a look? Thank you

@gjtempleton
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, mbdebian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 35a4253 into kubernetes:cluster-autoscaler-release-1.24 May 2, 2023
5 checks passed
@ff-apple
Copy link
Contributor

ff-apple commented May 2, 2023

@gjtempleton Thank you!

I assume to have this released as patch will take some time in the next release cycle?

@mbdebian
Copy link
Author

mbdebian commented May 2, 2023

Thank you so much!

@gjtempleton
Copy link
Member

@ff-apple Yep, I'm currently scheduled to cut the next set of patch releases next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants