Fix somes cleanup things for addon-resizer. #5688
Conversation
Signed-off-by: yanggang <gang.yang@daocloud.io>
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yanggangtony The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/vertical-pod-autoscaler
size/S
| @@ -130,11 +130,9 @@ func main() { | |||
| log.Infof("Recommended range +/-%d%%", *recommendationOffset) | |||
|
|
|||
| var kubeClient kubernetes.Interface | |||
| _, err := rest.InClusterConfig() | |||
| if err != nil { | |||
| kubeClient = GetClientOrDie() | |||
There was a problem hiding this comment.
I don't understand this change
There was a problem hiding this comment.
@jbartosik
thanks your review..
the code GetClientOrDie has the same logic about rest.InClusterConfig() .
And will behave the same logic like now ..
But it is just chore cleanup. I will be glad to rollback. If you think its not necessary..😂😂
There was a problem hiding this comment.
@yanggangtony you can just close this PR as the changes are not necessary. (as per above comment)
| @@ -67,7 +67,7 @@ The current default version is Vertical Pod Autoscaler 0.13.0 | |||
| **NOTE:** In 0.13.0 we deprecate `autoscaling.k8s.io/v1beta2` API. We plan to | |||
| remove this API version. While for now you can continue to use `v1beta2` API we | |||
| recommend using `autoscaling.k8s.io/v1` instead. `v1` and `v1beta2` APIs are | |||
| almost identical (`v1` API has some fields which are not present in `v1beta2) | |||
| almost identical (`v1` API has some fields which are not present in `v1beta2`) | |||
There was a problem hiding this comment.
This is already resolved by PR #5823
|
I closed the PR because it seems it's no longer necessary; Please reopen if you disagree |
|
thanks. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
some cleanup for the
addon-resizer, and other readme typos...