Use TemplateNodeInfo in scale up #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
MaciekPytel
reviewed
May 16, 2017
cluster-autoscaler/core/utils.go
Outdated
| baseNodeInfo, err := nodeGroup.TemplateNodeInfo() | ||
| if err != nil && err != cloudprovider.ErrNotImplemented { | ||
| return map[string]*schedulercache.NodeInfo{}, err | ||
| } |
There was a problem hiding this comment.
if err == cloudprovider.ErrNotImplemented {
continue
}
?
There was a problem hiding this comment.
Actually can we also log before continue?
MaciekPytel
reviewed
May 16, 2017
cluster-autoscaler/core/utils.go
Outdated
| result := make(map[string]*schedulercache.NodeInfo) | ||
| for _, node := range nodes { | ||
|
|
||
| // Broken nodes might have some stuff missing. Skipping. | ||
| if !kube_util.IsNodeReadyAndSchedulable(node) { |
There was a problem hiding this comment.
I see the point of this, but I think it has a pretty big impact. In particular I'm worried about a scenario where the only node in node group becomes unready and TemplateNodeInfo is not implemented. Wouldn't that basically be non-recoverable with this change?
There was a problem hiding this comment.
Removing. Next PR.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
yaroslava-serdiuk
pushed a commit
to yaroslava-serdiuk/autoscaler
that referenced
this pull request
Feb 22, 2024
Add integration test framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #43