-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TemplateNodeInfo in scale up #71
Conversation
cluster-autoscaler/core/utils.go
Outdated
baseNodeInfo, err := nodeGroup.TemplateNodeInfo() | ||
if err != nil && err != cloudprovider.ErrNotImplemented { | ||
return map[string]*schedulercache.NodeInfo{}, err | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if err == cloudprovider.ErrNotImplemented {
continue
}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually can we also log before continue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
cluster-autoscaler/core/utils.go
Outdated
result := make(map[string]*schedulercache.NodeInfo) | ||
for _, node := range nodes { | ||
|
||
// Broken nodes might have some stuff missing. Skipping. | ||
if !kube_util.IsNodeReadyAndSchedulable(node) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the point of this, but I think it has a pretty big impact. In particular I'm worried about a scenario where the only node in node group becomes unready and TemplateNodeInfo is not implemented. Wouldn't that basically be non-recoverable with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing. Next PR.
/lgtm |
Add integration test framework
ref: #43