Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/cert-manager]: Add support for affinity and tolerations #3857

Closed
wants to merge 1 commit into from

Conversation

kiall
Copy link
Collaborator

@kiall kiall commented Feb 24, 2018

Adds support for setting the node affinity and tolerations scheduling options

Adds support for setting the node affinity and tolerations scheduling options
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kiall
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @kiall. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2018
@unguiculus
Copy link
Member

cc @munnerz

@unguiculus
Copy link
Member

@kiall The upstream version of the cert-manager chart in the cert-manager repo: https://github.com/jetstack/cert-manager/tree/master/contrib/charts/cert-manager. The Jetstack folks prefer to make changes there and then push them over here. You may want to reopen a PR over there.

@unguiculus unguiculus self-assigned this Feb 25, 2018
@kiall
Copy link
Collaborator Author

kiall commented Feb 26, 2018

I've submitted a copy of this PR over @ cert-manager/cert-manager#350

Will close this for now!

@kiall kiall closed this Feb 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants