Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Enable RBAC by default on nginx-ingress #5169

Merged
merged 3 commits into from
May 11, 2018
Merged

Conversation

affix
Copy link
Contributor

@affix affix commented Apr 20, 2018

What this PR does / why we need it:

Enable RBAC by default on nginx-ingress

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #5023

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2018
@Jokero
Copy link
Contributor

Jokero commented Apr 21, 2018

@affix Update chart version to 0.17.0 please.

@affix
Copy link
Contributor Author

affix commented Apr 21, 2018

@Jokero Updated, thanks for pointing it out

@Jokero
Copy link
Contributor

Jokero commented Apr 21, 2018

/assign @prydonius

@unguiculus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 11, 2018
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Affix, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2018
@k8s-ci-robot k8s-ci-robot merged commit c60086e into helm:master May 11, 2018
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
* Enable RBAC by default on nginx-ingress

* Update Chart Version
or1can pushed a commit to or1can/charts that referenced this pull request Jul 10, 2018
* Enable RBAC by default on nginx-ingress

* Update Chart Version
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
* Enable RBAC by default on nginx-ingress

* Update Chart Version

Signed-off-by: voron <av@arilot.com>
hickey pushed a commit to hickey/charts that referenced this pull request Jun 12, 2019
* Enable RBAC by default on nginx-ingress

* Update Chart Version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stable/nginx-ingress] Enable RBAC by default
5 participants