This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/sonarqube] Add MySQL database support to Sonarqube #5803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow has an option to store data in MySQL database too, It already had a support to store the data in Postgres. A given release could now have either Postgres database (internal / external) or MySQL database (internal / external).
Updated README.md to add configuration changes that come with MySQL database support.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/L
k8s-ci-robot
added
size/M
rjkernick
suggested changes
May 29, 2018
stable/sonarqube/Chart.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| name: sonarqube | |||
| description: Sonarqube is an open sourced code quality scanning tool | |||
| version: 0.6.0 | |||
| version: 0.6.1 | |||
There was a problem hiding this comment.
Please bump the minor version since this adds a new feature
| heritage: {{ .Release.Service }} | ||
| type: Opaque | ||
| data: | ||
| postgres-password: {{ .Values.mysql.mysqlPassword | b64enc | quote }} |
There was a problem hiding this comment.
Key should be mysql-password
There was a problem hiding this comment.
Ah my bad , this is a blunder .
| @@ -12,3 +12,18 @@ type: Opaque | |||
| data: | |||
| postgres-password: {{ .Values.postgresql.postgresPassword | b64enc | quote }} | |||
| {{- end -}} | |||
| {{- if eq .Values.mysql.enabled false -}} | |||
There was a problem hiding this comment.
We also only need this if the database type is mysql. Same with the postgres secret above only is needed is database is postgres and postgres is disabled.
There was a problem hiding this comment.
Added the check , thanks for pointing out
1. Bumped the minor version of the chart since it's a feature release 2. Added check for database type while populating secrets 3. Corrected mysql key
k8s-ci-robot
added
size/L
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
I am going to try and test out the different combinations this afternoon before I merge it. Thanks for the quick turnaround on the changes! |
|
Sure, let me know if you find any issues . Thanks !! |
|
/assign |
|
@rjkernick Can we go ahead with merging . |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irajdeep, rjkernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
or1can
pushed a commit
to or1can/charts
that referenced
this pull request
Jul 10, 2018
* Added MySQL database support to Sonarqube, the Sonarqube helm chart now has an option to store data in MySQL database too, It already had a support to store the data in Postgres. A given release could now have either Postgres database (internal / external) or MySQL database (internal / external). * Updated README.md Updated README.md to add configuration changes that come with MySQL database support. * Removing white spaces to get rid of helm lint errors * Yes another attempt to remove trailing spaces :( * Fixing PR comments 1. Bumped the minor version of the chart since it's a feature release 2. Added check for database type while populating secrets 3. Corrected mysql key
voron
pushed a commit
to dysnix/helm-charts
that referenced
this pull request
Sep 5, 2018
* Added MySQL database support to Sonarqube, the Sonarqube helm chart now has an option to store data in MySQL database too, It already had a support to store the data in Postgres. A given release could now have either Postgres database (internal / external) or MySQL database (internal / external). * Updated README.md Updated README.md to add configuration changes that come with MySQL database support. * Removing white spaces to get rid of helm lint errors * Yes another attempt to remove trailing spaces :( * Fixing PR comments 1. Bumped the minor version of the chart since it's a feature release 2. Added check for database type while populating secrets 3. Corrected mysql key Signed-off-by: voron <av@arilot.com>
|
In the sonarqube 7.1 version, mysql support was |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds
MySQLdatabase support to Sonarqube. Currently Sonarqube has onlyPostgresqlsupport to store the data. It has the relevant changes to the template files and README.md for the new MySQL database supportWhich issue this PR fixes *
fixes #5654
Special notes for your reviewer:
/assign@rjkernick