Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kapacitor] Supply kapacitor.conf via ConfigMap/values.yaml #674

Closed
wants to merge 2 commits into from

Conversation

jagregory
Copy link
Contributor

Added support to generate a kapacitor.conf from values.yaml.

By default the config generated will mirror the default config Kapacitor uses. See generated with this chart vs the default kapacitor config.

The only difference between the YAML and the TOML is using a kapacitor key to contain the top-level config options, which need to be pulled out separately due to TOML being order-sensitive.

Without this, Kapacitor isn't very useful because you can't use the alerts without enabling a notification in the config.

@k8s-ci-robot
Copy link
Contributor

Hi @jagregory. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2017
@jackzampolin
Copy link
Contributor

@jagregory You can enable the notifications through the API or through our dashboarding tool Chronograf. Relying on a config file breaks the latter functionality so I've implemented it in the ENV you see.

Another note on this approach, I've just submitted a PR to kubernetes/helm that adds a toToml template function that might make this code cleaner.

@viglesiasce
Copy link
Contributor

@jackzampolin can we close this out?

@jackzampolin
Copy link
Contributor

@viglesiasce Yup!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting review cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants