Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s 1.7 corresponding release of client-go #231

Closed
hongchaodeng opened this issue Jun 30, 2017 · 14 comments
Closed

k8s 1.7 corresponding release of client-go #231

hongchaodeng opened this issue Jun 30, 2017 · 14 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@hongchaodeng
Copy link
Contributor

k8s 1.7 is released.
When is client-go doing a release to match that?

@ericchiang
Copy link
Contributor

cc @caesarxuchao who had some thoughts on this.

@caesarxuchao caesarxuchao self-assigned this Jun 30, 2017
@caesarxuchao
Copy link
Member

caesarxuchao commented Jun 30, 2017

Because the pkg/api pkg/apis are all removed (for good), so we have breaking changes again, so it will be client-go release-4.0. I'll set it up. edit: they are removed in master, not 1.7, so it will affect only next release.

It's insane to bump the major version every quarter. I'll open another issue discussing how to enabling API tests and integration tests for client-go, and eventually decouple the release from kubernetes.

@lavalamp
Copy link
Member

lavalamp commented Jun 30, 2017 via email

@caesarxuchao
Copy link
Member

caesarxuchao commented Jun 30, 2017

We do not back-port new API groups or new features like leader election across major releases. Users who want to use these features need to upgrade, their life will be easier if we don't bump the major version often.

@tamalsaha
Copy link
Member

We do now back-port new API groups or new features like leader election across major releases.

Do you mind elaborating on that? We write operators for Kubernetes. Dealing with breaking changes with every release of Kubernetes is a major headache for us.

@joshwget
Copy link

joshwget commented Jul 6, 2017

Because the pkg/api pkg/apis are all removed (for good), so we have breaking changes again, so it will be client-go release-4.0. I'll set it up.

Isn't this code imported in various places in 1.7? For those looking for a client-go release to use when importing code from Kubernetes 1.7 this wouldn't work.

@caesarxuchao
Copy link
Member

@joshwget sorry, i took that back. pkg/api and pkg/apis are still there in kubernetes/release-1.7, so they will be in the client-go branch that tracks kubernetes/release-1.7.

@joshwget
Copy link

joshwget commented Jul 6, 2017

Awesome, thanks for confirming that.

@lavalamp
Copy link
Member

lavalamp commented Jul 7, 2017

Users who want to use these features need to upgrade, their life will be easier if we don't bump the major version often.

I just want to point out that users who want new features and also don't want to upgrade want a logically impossible thing. ;)

@caesarxuchao
Copy link
Member

I created the release-4.0 branch. Now i need to manually fill out the CHANGELOG, then release the v4.0.0.

@caesarxuchao
Copy link
Member

I made the v4.0.0-beta.0 tag. I'll gvie the beta.0 one week time to soak and create v4.0.0 tag next week.

@svInfra17
Copy link

@caesarxuchao , is v4.0.0-beta.0 ready for v4.0.0 ?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 2, 2018
@nikhita
Copy link
Member

nikhita commented Jan 2, 2018

This is fixed now and the README and CHANGELOG are updated.

Closing.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

10 participants