NetworkPolicyPort requires pointer to const for Protocol

[donovansolms]

I found an inconsistency for specifying the Protocol for ingress and egress network policies that requires a workaround since Go doesn't allow getting a const address directly.

Client Version: client-go 5.0
Kubernetes Version: 1.8

In other areas where you need to specify a protocol/port combination, such as ServicePort you can do:

v1.ServiceSpec{
	Ports: []v1.ServicePort{
		{
			Protocol: v1.ProtocolUDP, // Use the const directly
		},
	},
}

However, in NetworkPolicyPort you need to provide a pointer to the Protocol constant.

Ports: []networkv1.NetworkPolicyPort{
    {
        // This can't be done in Go directly
        // error: cannot take the address of "k8s.io/api/core/v1".ProtocolUDP
        Protocol: &v1.ProtocolUDP,
        Port: &intstr.IntOrString{
            Type:   intstr.Int,
            IntVal: int32(53),
        },
    },
},

To make this work you need to assign the const to a variable that you can get the address of and use that. This feels wrong to me.

const protocolConst = v1.ProtocolUDP
protocolVar := protocolConst

Ports: []networkv1.NetworkPolicyPort{
    {
        Protocol: &protocolVar,
        Port: &intstr.IntOrString{
            Type:   intstr.Int,
            IntVal: int32(53),
        },
    },
},

The differences can be found in core api/types and networking api/types.

This isn't really an issue as the code works as expected, it just requires an odd workaround to make it work. Am I missing something here? Is there a specific reason why this would require a pointer?

Note: I could not see any reason why it would be generated as such since there is no real difference in the protobuf definitions for NetworkPolicyPort and ServicePort

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[timthelion]

I think you're supposed to use the Enum method: https://stackoverflow.com/questions/50464205/how-to-set-a-protobuf2-enum-using-golang