Issue at compilation time when required with dep #417

seblegall · 2018-05-23T13:03:27Z

Hi,

It seems that there is a compilation error when the client-go is required from dep.

The dep ensure command goes well. But then... go build output this error :

# github.com/seblegall/test-k8s-go-client/vendor/k8s.io/client-go/discovery
vendor/k8s.io/client-go/discovery/restmapper.go:42:75: undefined: meta.VersionInterfacesFunc
vendor/k8s.io/client-go/discovery/restmapper.go:176:19: undefined: meta.VersionInterfacesFunc

Steps to reproduce this error :

Copy past the source code from : https://github.com/kubernetes/client-go/blob/master/examples/out-of-cluster-client-configuration/main.go in new project.
Run dep init
Run go build

I originally had this trouble when trying to do a dep update on project that use this dependency : https://github.com/Meetic/blackbeard

I'm using : go version go1.9.2 darwin/amd64

dep version output (I'm using dep build from source and I'm up to date with master) :

dep:
 version     : devel
 build date  :
 git hash    :
 go version  : go1.9.2
 go compiler : gc
 platform    : darwin/amd64
 features    : ImportDuringSolve=false

The text was updated successfully, but these errors were encountered:

liggitt · 2018-05-23T13:34:03Z

what branches are you using?

seblegall · 2018-05-23T13:52:29Z

My Gopkg.toml file contains :

[[constraint]]
  name = "k8s.io/client-go"
  version = "7.0.0"

The Gopkg.lock file contains :

[[projects]]
  name = "k8s.io/client-go"
  packages = [
    "discovery",
    "kubernetes",
    "kubernetes/scheme",
    "kubernetes/typed/admissionregistration/v1alpha1",
    "kubernetes/typed/admissionregistration/v1beta1",
    "kubernetes/typed/apps/v1",
    "kubernetes/typed/apps/v1beta1",
    "kubernetes/typed/apps/v1beta2",
    "kubernetes/typed/authentication/v1",
    "kubernetes/typed/authentication/v1beta1",
    "kubernetes/typed/authorization/v1",
    "kubernetes/typed/authorization/v1beta1",
    "kubernetes/typed/autoscaling/v1",
    "kubernetes/typed/autoscaling/v2beta1",
    "kubernetes/typed/batch/v1",
    "kubernetes/typed/batch/v1beta1",
    "kubernetes/typed/batch/v2alpha1",
    "kubernetes/typed/certificates/v1beta1",
    "kubernetes/typed/core/v1",
    "kubernetes/typed/events/v1beta1",
    "kubernetes/typed/extensions/v1beta1",
    "kubernetes/typed/networking/v1",
    "kubernetes/typed/policy/v1beta1",
    "kubernetes/typed/rbac/v1",
    "kubernetes/typed/rbac/v1alpha1",
    "kubernetes/typed/rbac/v1beta1",
    "kubernetes/typed/scheduling/v1alpha1",
    "kubernetes/typed/settings/v1alpha1",
    "kubernetes/typed/storage/v1",
    "kubernetes/typed/storage/v1alpha1",
    "kubernetes/typed/storage/v1beta1",
    "pkg/apis/clientauthentication",
    "pkg/apis/clientauthentication/v1alpha1",
    "pkg/version",
    "plugin/pkg/client/auth/exec",
    "rest",
    "rest/watch",
    "tools/auth",
    "tools/clientcmd",
    "tools/clientcmd/api",
    "tools/clientcmd/api/latest",
    "tools/clientcmd/api/v1",
    "tools/metrics",
    "tools/reference",
    "transport",
    "util/cert",
    "util/flowcontrol",
    "util/homedir",
    "util/integer"
  ]
  revision = "23781f4d6632d88e869066eaebb743857aa1ef9b"
  version = "v7.0.0"

So, I'm using the v7.0.0 tag.

liggitt · 2018-05-23T13:58:12Z

client-go v7.0.0 depends on k8s.io/apimachinery 31dade610c053669d8054bfd847da657251e8c1a:

https://github.com/kubernetes/client-go/blob/v7.0.0/Godeps/Godeps.json#L373-L376

the referenced type exists at that revision https://github.com/kubernetes/apimachinery/blob/31dade610c053669d8054bfd847da657251e8c1a/pkg/api/meta/restmapper.go#L90-L92

sttts · 2018-05-23T14:01:06Z

With dep you have to pin all dependencies (especially those under the k8s.io org) to the right versions. For client-go 7.0.0 use the kubernetes-1.10.0 tags on the other k8s.io repos.

seblegall · 2018-05-23T15:15:35Z

@sttts It works when specifying the version instead of branch in the Gopkg.toml.

However... isn't wired that the default use case with dep doesn't work?

I'm not an expert of dep but... couldn't we find a solution to make client-go explicitly require version
kubernetes-1.10.0 of apimachinery ?

sttts · 2018-05-29T07:25:20Z

@seblegall compare kubernetes/publishing-bot#55. Looks like dep's SAT algorithm falls over. Actually though, nobody has found out whether we have a mistake in our (experimentally) shipped Gopkg.tomls or whether dep just explodes.

seblegall · 2018-05-29T12:05:59Z

@sttts Well, did you also try to migrate to vgo? 🤣

sttts · 2018-05-29T12:08:25Z

Well, did you also try to migrate to vgo?

I think nobody dared to try that yet for the whole kube. Maybe just for client-go and friends it's feasible.

seblegall · 2018-05-30T07:45:04Z

I may take some time in the next few days to test vgo on my own project (that require the go-client), then, I may test vgo also on the go-client. Keep you updated.

ilackarms · 2018-05-31T19:05:42Z

also running into this issue with dep

aalubin · 2018-06-03T05:27:17Z

+1

cheynewallace · 2018-06-04T23:59:28Z

Also having this issue.. Can anyone suggest a fix? Im blocked right now

seblegall · 2018-06-05T07:50:09Z

You have to put this explicitly in your Gopkg.toml file :

[[constraint]]
  name = "k8s.io/api"
  version = "kubernetes-1.9.0"

[[constraint]]
  name = "k8s.io/apimachinery"
  version = "kubernetes-1.9.0"

[[constraint]]
  name = "k8s.io/client-go"
  version = "6.0.0"

In this example I have set the version to kubernetes-1.9.0 because I'm using the client-go version 6.0.0. But you should put the right version of k8s.io/* packages depending on the client-go you are using.

aalubin · 2018-06-05T12:33:05Z

@cheynewallace setting the client-go to reference master solves the problem as well:

[[constraint]]
  name = "k8s.io/client-go"
  branch = "master"

sttts · 2018-06-05T12:59:12Z

setting the client-go to reference master solves the problem as well:

not a good idea. We have no guarantees whatsoever about compatibility with former or future Kube versions.

aalubin · 2018-06-05T13:05:40Z

@sttts, you are absolutely right. I should have added a warning for this workaround.

cheynewallace · 2018-06-06T06:37:42Z

Thanks @seblegall , that one solved it for me..

sigma · 2018-06-08T08:00:00Z

I think nobody dared to try that yet for the whole kube. Maybe just for client-go and friends it's feasible.

actually I did try, and indeed I ended up in a situation where all staging repositories were behaving, but no solution could be found for the main repo.
As far as I can tell, the combination of excessive v0.0.0-* fake versions (really v2+) and dependency cycles in the implicit vgo modules was deadly

sttts · 2018-06-11T08:55:10Z

@sigma am curious, can you upload your experiments to a branch?

nikhita · 2018-07-05T09:32:38Z

vgo and kubernetes: kubernetes/kubernetes#65683 ✨

idealhack · 2018-07-10T02:15:35Z

About dep, I found that it works well to use the same tag for client-go, api and apimachinery. Could this be the recommended way when pinning dependencies?

ref: kubernetes/api#5 (comment)

sttts · 2018-07-10T08:04:37Z

Could this be the recommended way when pinning dependencies?

Yes, that's recommended.

fejta-bot · 2018-10-08T08:48:59Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

808codist · 2018-10-31T20:32:36Z

@seblegall wrote:

you should put the right version of k8s.io/* packages depending on the client-go you are using

How does one go about finding the "right version of k8s.io/*", given a certain client-go version, e.g. v9.0.0?

ash2k · 2018-10-31T22:36:13Z

@808codist Give this tool a try https://github.com/ash2k/kubegodep2dep

fejta-bot · 2018-11-30T22:50:26Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · 2018-12-30T23:34:20Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2018-12-30T23:34:27Z

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

seblegall changed the title ~~Issue at compilation when required with dep~~ Issue at compilation time when required with dep May 23, 2018

kirs mentioned this issue May 24, 2018

Fix dependencies dragonsmith/tiller-releases-converter#1

Merged

ntfrnzn mentioned this issue May 26, 2018

Vendoring in kubernetes is breaking the build after dep ensure virtual-kubelet/virtual-kubelet#209

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 8, 2018

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 30, 2018

k8s-ci-robot closed this as completed Dec 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue at compilation time when required with dep #417

Issue at compilation time when required with dep #417

seblegall commented May 23, 2018

liggitt commented May 23, 2018

seblegall commented May 23, 2018

liggitt commented May 23, 2018 •

edited

sttts commented May 23, 2018

seblegall commented May 23, 2018

sttts commented May 29, 2018

seblegall commented May 29, 2018

sttts commented May 29, 2018

seblegall commented May 30, 2018

ilackarms commented May 31, 2018

aalubin commented Jun 3, 2018

cheynewallace commented Jun 4, 2018

seblegall commented Jun 5, 2018

aalubin commented Jun 5, 2018

sttts commented Jun 5, 2018

aalubin commented Jun 5, 2018

cheynewallace commented Jun 6, 2018

sigma commented Jun 8, 2018

sttts commented Jun 11, 2018

nikhita commented Jul 5, 2018

idealhack commented Jul 10, 2018

sttts commented Jul 10, 2018

fejta-bot commented Oct 8, 2018

808codist commented Oct 31, 2018

ash2k commented Oct 31, 2018

fejta-bot commented Nov 30, 2018

fejta-bot commented Dec 30, 2018

k8s-ci-robot commented Dec 30, 2018

Issue at compilation time when required with dep #417

Issue at compilation time when required with dep #417

Comments

seblegall commented May 23, 2018

liggitt commented May 23, 2018

seblegall commented May 23, 2018

liggitt commented May 23, 2018 • edited

sttts commented May 23, 2018

seblegall commented May 23, 2018

sttts commented May 29, 2018

seblegall commented May 29, 2018

sttts commented May 29, 2018

seblegall commented May 30, 2018

ilackarms commented May 31, 2018

aalubin commented Jun 3, 2018

cheynewallace commented Jun 4, 2018

seblegall commented Jun 5, 2018

aalubin commented Jun 5, 2018

sttts commented Jun 5, 2018

aalubin commented Jun 5, 2018

cheynewallace commented Jun 6, 2018

sigma commented Jun 8, 2018

sttts commented Jun 11, 2018

nikhita commented Jul 5, 2018

idealhack commented Jul 10, 2018

sttts commented Jul 10, 2018

fejta-bot commented Oct 8, 2018

808codist commented Oct 31, 2018

ash2k commented Oct 31, 2018

fejta-bot commented Nov 30, 2018

fejta-bot commented Dec 30, 2018

k8s-ci-robot commented Dec 30, 2018

liggitt commented May 23, 2018 •

edited