Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Network Policies #57

Closed
FlorianOtel opened this issue Dec 20, 2016 · 5 comments
Closed

Support for Network Policies #57

FlorianOtel opened this issue Dec 20, 2016 · 5 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@FlorianOtel
Copy link

Hello all,

As described in this thread, I've discovered that the existing "client-go" package does not yet support extension methods for network policies.

By modelling it after existing support for PodSecurityPolicy -- and some help from the main repository -- I have now implemented those methods.

They are located in my fork here: https://github.com/FlorianOtel/client-go

However, it seems that any PRs have to be submitted via main repo, as opposed to directly here.

Unless otherwise advised, I will try doing so next.

Submitting this issue here for reference.

Thanks,

/Florian

@caesarxuchao
Copy link
Member

Hi Florian, the reason NetworkPolicy is missing in the client-go is because this tag is missing in the pkg/apis/extensions/v1beta1/types.go.

To fix it, in the main repo,

  1. add the // +genclient=true to pkg/apis/extensions/v1beta1/types.go.
  2. run hack/update-codegen.sh
  3. run hack/update-staging-client-go.sh

After the PR gets merged, the changes will be populated to client-go in 24 hours.

@FlorianOtel
Copy link
Author

Hi,

Kindest thanks for the guidance, much appreciated -- esp. considering this is my first K8S PR :)

I've submitted the pull request already -- it's PR #39155

Thanks,

/Florian

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 21, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

openshift-publish-robot pushed a commit to openshift/kubernetes-client-go that referenced this issue Apr 25, 2018
…1.10.0

Update kube-openapi, regenerate openapi package

Kubernetes-commit: f56472afd3cc07125f8690303aec1215035cc267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants