Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe "gnostic" should be updated #636

Closed
nghialv opened this issue Jul 17, 2019 · 4 comments
Closed

Maybe "gnostic" should be updated #636

nghialv opened this issue Jul 17, 2019 · 4 comments

Comments

@nghialv
Copy link

nghialv commented Jul 17, 2019

Hi

We are using client-go with bazel and rules-go, gazelle and got the following output

/private/var/tmp/_bazel_a13705/d47ee6d5190331e265fc3deb51db2812/external/bazel_gazelle/internal/go_repository.bzl:184:13: gazelle: gazelle: finding module path for import github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/apis_guru/apis_guru: exit status 1: go: finding github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/apis_guru/apis_guru latest
go: finding github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/apis_guru latest
go: finding github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples latest
go: finding github.com/googleapis/gnostic/plugins/gnostic-go-generator latest
go: finding github.com/googleapis/gnostic/plugins latest
can't load package: package github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/apis_guru/apis_guru: unknown import path "github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/apis_guru/apis_guru": cannot find module providing package github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/apis_guru/apis_guru
gazelle: finding module path for import github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/bookstore/bookstore: exit status 1: go: finding github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/bookstore/bookstore latest
go: finding github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/bookstore latest
go: finding github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples latest
go: finding github.com/googleapis/gnostic/plugins/gnostic-go-generator latest
go: finding github.com/googleapis/gnostic/plugins latest
can't load package: package github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/bookstore/bookstore: unknown import path "github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/bookstore/bookstore": cannot find module providing package github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/bookstore/bookstore
gazelle: finding module path for import github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/bookstore/bookstore: exit status 1: go: finding github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/bookstore/bookstore latest
go: finding github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/bookstore latest
go: finding github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples latest
go: finding github.com/googleapis/gnostic/plugins/gnostic-go-generator latest
go: finding github.com/googleapis/gnostic/plugins latest
can't load package: package github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/bookstore/bookstore: unknown import path "github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/bookstore/bookstore": cannot find module providing package github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/bookstore/bookstore
gazelle: finding module path for import github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/xkcd/xkcd: exit status 1: go: finding github.com/googleapis/gnostic/plugins/gnostic-go-generator/examples/v2.0/xkcd/xkcd latest
@sttts
Copy link
Contributor

sttts commented Jul 18, 2019

Do you depend on the right version?

https://github.com/kubernetes/client-go/blob/master/go.mod#L17

@nghialv
Copy link
Author

nghialv commented Jul 18, 2019

Thank for your reply.
Yes, I am using the right version.
I checked the import graph then knew that this is not problem from client-go but kube-openapi.

I am using

k8s.io/api v0.0.0-20190717022910-653c86b0609b
k8s.io/apimachinery v0.0.0-20190717022731-0bb8574e0887
k8s.io/client-go v0.0.0-20190717023132-0c47f9da0001
k8s.io/code-generator v0.0.0-20190717022600-77f3a1fe56bb

And the import graph is

k8s.io/apimachinery@v0.0.0-20190717022731-0bb8574e0887 -> k8s.io/kube-openapi@v0.0.0-20190709113604-33be087ad058 -> github.com/googleapis/gnostic@v0.0.0-20170426233943-68f4ded48ba9

https://github.com/kubernetes/kube-openapi/blob/master/go.mod#L18

So firstly, the gnostic version at kube-openapi should be updated, then k8s.io/apimachinery.

I will fire another issue on kube-openapi and close this.
Thank you.

@nghialv
Copy link
Author

nghialv commented Jul 18, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@nghialv: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants