add Timeout field to REST client (1.4, 1.5) config #10
Conversation
Fixes test panics in k8s PR: kubernetes/kubernetes#33958 and OpenShift PR: openshift/origin#11104 The linked Kubernetes PR adds a "Timeout" field to the rest client in order to implement global http request timeouts for server requests.
|
Code changes should be made in the main kubernetes repo. This repo is published from there by a bot. Sorry, I know this is terribly inconvenient-- I will try and get a message to appear when people open PRs. |
|
@lavalamp Thanks for the info, will do. When I attempted to update |
|
@juanvallejo sorry for misinformation, I didn't know either :( |
|
The /staging directory is still not the source. You need to change the actual source and run staging/copy.sh. You can look at copy.sh to see what gets copied into the package you're trying to change. |
|
@soltysh completely fine, I'm just happy to see different kinds of test failures on the PR now :) |
|
@lavalamp I tried running |
|
It probably hasn't been run for a few days. @caesarxuchao does that look On Fri, Oct 7, 2016 at 4:21 PM, Juan Vallejo notifications@github.com
|
|
kubernetes/kubernetes#31994 is merged recently, but we didn't run copy.sh after that, so most diffs are caused by that. Note that #31994 is a breaking change, if we are going to follow semver, we'll need to bump client-go to v2.0.0. We need to make a decision for #9 soon. |
|
Gotcha. hrm. On Fri, Oct 7, 2016 at 4:40 PM, Chao Xu notifications@github.com wrote:
|
…t-flag Automatic merge from submit-queue Add global timeout flag **Release note**: ```release-note Add a new global option "--request-timeout" to the `kubectl` client ``` UPSTREAM: kubernetes/client-go#10 This patch adds a global timeout flag (viewable with `kubectl -h`) with a default value of `0s` (meaning no timeout). The timeout value is added to the default http client, so that zero values and default behavior are enforced by the client. Adding a global timeout ensures that user-made scripts won't hang for an indefinite amount of time while performing remote calls (right now, remote calls are re-tried up to 10 times when each attempt fails, however, there is no option to set a timeout in order to prevent any of these 10 attempts from hanging indefinitely). **Example** ``` $ kubectl get pods # no timeout flag set - default to 0s (which means no timeout) NAME READY STATUS RESTARTS AGE docker-registry-1-h7etw 1/1 Running 1 2h router-1-uv0f9 1/1 Running 1 2h $ kubectl get pods --request-timeout=0 # zero means no timeout no timeout flag set NAME READY STATUS RESTARTS AGE docker-registry-1-h7etw 1/1 Running 1 2h router-1-uv0f9 1/1 Running 1 2h $kubectl get pods --request-timeout=1ms Unable to connect to the server: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers) ```
Remove LICENSE
Fixes test panics in k8s PR:
kubernetes/kubernetes#33958
and OpenShift PR: openshift/origin#11104
The linked Kubernetes PR adds a "Timeout" field to the rest client in
order to implement global http request timeouts for server requests.
@soltysh @fabianofranz