Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go modules to include latest k8s.io/kubernetes module on v-1.19 #146

Merged
merged 1 commit into from Oct 26, 2020
Merged

Update go modules to include latest k8s.io/kubernetes module on v-1.19 #146

merged 1 commit into from Oct 26, 2020

Conversation

nicolehanjing
Copy link
Member

@nicolehanjing nicolehanjing commented Oct 21, 2020 •
edited

update go modules to include latest k8s.io/kubernetes module on release-1.19 branch

$ go get -u k8s.io/kubernetes
go: k8s.io/kubernetes upgrade => v1.19.3

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
patched v1.19 for v2 Instance kubernetes/kubernetes#95452 and update go.mod to include the latest version

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 21, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2020
@nicolehanjing
Copy link
Member Author

/cc @andrewsykim

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2020
@andrewsykim
Copy link
Member

@nicolehanjing can you link the PR with the bug fix we're trying to pull in ?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2020
@nicolehanjing
Copy link
Member Author

@nicolehanjing can you link the PR with the bug fix we're trying to pull in ?

sure, updated the PR description

@nicolehanjing nicolehanjing force-pushed the nicoleh-update branch 3 times, most recently from b3cc780 to 0daa734 Compare October 23, 2020 17:28
andrewsykim
andrewsykim reviewed Oct 23, 2020
View reviewed changes
go.mod Outdated
@@ -42,7 +42,7 @@ require (
k8s.io/component-base v0.0.0
k8s.io/klog v1.0.0
k8s.io/klog/v2 v2.2.0
k8s.io/kubernetes v1.19.1
k8s.io/kubernetes v1.19.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be v0.0.0-20201023141757-9e8ad8ce9d8a until we update this to v1.1.9.4 in a follow-up PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated! I also re-verify that the node registration worked after updating :)

andrewsykim
andrewsykim reviewed Oct 23, 2020
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on bumping AWS SDK, if we can get that back to v1.28.2, then lgtm!

go.mod Outdated
)

require (
github.com/aws/aws-sdk-go v1.28.2
github.com/aws/aws-sdk-go v1.35.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to bump aws-sdk-go in this PR? If we can keep v1.28.2 that would be ideal since k8s.io/kubernetes v1.19 is still on v1.28.2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, updated!

@nicolehanjing nicolehanjing force-pushed the nicoleh-update branch 2 times, most recently from 21f3b15 to e1ae03d Compare October 23, 2020 23:31
andrewsykim
andrewsykim reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, nicolehanjing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit accb0dc into kubernetes:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@justinsb justinsb Awaiting requested review from justinsb

@nckturner nckturner Awaiting requested review from nckturner

Assignees

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolehanjing @andrewsykim @k8s-ci-robot