Release v1.23.0-alpha.0 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
nckturner
commented
Jan 7, 2022
| @@ -28,7 +28,7 @@ spec: | |||
| serviceAccountName: cloud-controller-manager | |||
| containers: | |||
| - name: aws-cloud-controller-manager | |||
| image: us.gcr.io/k8s-artifacts-prod/provider-aws/cloud-controller-manager:v1.22.0-alpha.0 | |||
| image: us.gcr.io/k8s-artifacts-prod/provider-aws/cloud-controller-manager:v1.23.0-alpha.0 | |||
There was a problem hiding this comment.
There is a race condition here since we won't create this tag and trigger the container build until after this PR merges..
|
Are you releasing 1.22 or 1.23 here? Code says the latter, title the former. |
nckturner
force-pushed
the
release-1.23
branch
from
b3b0bbc
to
8af45a8
Compare
* Add changelog. * Add entry to README table. * Rewrite release instructions. * Update helm workflow to run on release branches.
nckturner
force-pushed
the
release-1.23
branch
from
8af45a8
to
8e8e8ea
Compare
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nckturner, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Release v1.23.0-alpha.0
Does this PR introduce a user-facing change?:
/cc @wongma7