Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch all history when tagging releases #396

Merged
merged 1 commit into from May 29, 2022
Merged

Fetch all history when tagging releases #396

merged 1 commit into from May 29, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented May 28, 2022

To be able to check if a tag already exists, all history has to be pulled during checkout:
https://github.com/actions/checkout#fetch-all-history-for-all-tags-and-branches

Without this, the job will fail when the tag already exists:
https://github.com/kubernetes/cloud-provider-aws/runs/6636986249?check_suite_focus=true

Ref: #388

/cc @olemarkus @nckturner

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2022
@hakman
Copy link
Member Author

hakman commented May 28, 2022

/triage accepted
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 28, 2022
@hakman
Copy link
Member Author

hakman commented May 28, 2022

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit ddfdf35 into kubernetes:master May 29, 2022
This was referenced Jun 10, 2022
Merged
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 21, 2022
@k8s-ci-robot
Merge pull request #402 from hakman/automated-cherry-pick-of-#388-#396-…
f09252f 
…upstream-release-1.23

Automated cherry pick of #388: Tag releases automatically
#396: Fetch all history when tagging releases
k8s-ci-robot added a commit that referenced this pull request Jun 21, 2022
@k8s-ci-robot
Merge pull request #403 from hakman/automated-cherry-pick-of-#388-#396-…
6e51fee 
…upstream-release-1.22

Automated cherry pick of #388: Tag releases automatically
#396: Fetch all history when tagging releases
k8s-ci-robot added a commit that referenced this pull request Jun 21, 2022
@k8s-ci-robot
Merge pull request #405 from hakman/automated-cherry-pick-of-#388-#396-…
4a1bfac 
…upstream-release-1.20

Automated cherry pick of #388: Tag releases automatically
#396: Fetch all history when tagging releases
k8s-ci-robot added a commit that referenced this pull request Jun 21, 2022
@k8s-ci-robot
Merge pull request #404 from hakman/automated-cherry-pick-of-#388-#396-…
2438521 
…upstream-release-1.21

Automated cherry pick of #388: Tag releases automatically
#396: Fetch all history when tagging releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@nckturner nckturner Awaiting requested review from nckturner

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hakman @k8s-ci-robot @olemarkus