Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golint failure in cloud-provider-gcp/cmd/auth-provider-gcp/app/getcredentials.go #199

Closed
cici37 opened this issue Apr 2, 2021 · 2 comments · Fixed by #201
Closed

Comments

@cici37
Copy link
Contributor

cici37 commented Apr 2, 2021

Golint check shows some suggestions in getcredentials.go
Screen Shot 2021-04-02 at 10 51 26 AM

Ref: #198

@cici37
Copy link
Contributor Author

cici37 commented Apr 2, 2021

/assign @DangerOnTheRanger

Would you mind to add some comments on this file to resolve golint failures? Thank you

@k8s-ci-robot
Copy link
Contributor

@cici37: GitHub didn't allow me to assign the following users: DangerOnTheRanger.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @DangerOnTheRanger

Would you mind to add some comments on this file to resolve golint failures? Thank you

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants