Update various k8s.io modules to v0.22.0

[sdmodi]

This was done by modifying the version of k8s.io/cloud-provider in go.mod and providers/go.mod to v0.22.0 and running ./tools/update_vendor.sh.

This change pulls in kubernetes/kubernetes#103951 which is required for correct bringup of the nodeipam controller in cloud-controller-manager.

[k8s-ci-robot]

Hi @sdmodi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdmodi
To complete the pull request process, please assign saad-ali after the PR has been reviewed.
You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jpbetz]

All the k8s v0.21.0 modules should be upgraded to v0.22.0 at the same time.

[jpbetz]

All the k8s v0.21.0 modules should be upgraded to v0.22.0 at the same time.

[sdmodi]

When I update k8s.io/kubernetes v1.21.0 to v1.22.0, I see this:

go: k8s.io/kubernetes@v1.22.0 requires
k8s.io/pod-security-admission@v0.0.0: reading k8s.io/pod-security-admission/go.mod at revision v0.0.0: unknown revision v0.0.0

How should I resolve this?

[Fedosin]

I believe you should add k8s.io/pod-security-admission => k8s.io/pod-security-admission v0.22.0 in the replace section.

[Fedosin]

I did this: openshift#2 It seems working.

[sdmodi]

I made progress on this and I am unable to commit the changes. Here is the message I see:

sdmodi@sdmodi-glaptop:~/go/src/cloud-provider-gcp$ git commit -a
vendor/k8s.io/client-go/plugin/pkg/client/auth/gcp/gcp.go:79://       "access-token": "ya29.CjWdA4GiBPTt",

[ERROR] Matched one or more prohibited patterns

Possible mitigations:
- Mark false positives as allowed using: git config --add secrets.allowed ...
- Mark false positives as allowed by adding regular expressions to .gitallowed at repository's root directory
- List your configured patterns: git config --get-all secrets.patterns
- List your configured allowed patterns: git config --get-all secrets.allowed
- List your configured allowed patterns in .gitallowed at repository's root directory
- Use --no-verify if this is a one-time false positive

This looks like a false positive because the git config for allowed secrets is this:

sdmodi@sdmodi-glaptop:~/go/src/cloud-provider-gcp$ git config --get-all secrets.patterns
(A3T[A-Z0-9]|AKIA|AGPA|AIDA|AROA|AIPA|ANPA|ANVA|ASIA)[A-Z0-9]{16}
("|')?(AWS|aws|Aws)?_?(SECRET|secret|Secret)?_?(ACCESS|access|Access)?_?(KEY|key|Key)("|')?\s*(:|=>|=)\s*("|')?[A-Za-z0-9/\+=]{40}("|')?
("|')?(AWS|aws|Aws)?_?(ACCOUNT|account|Account)_?(ID|id|Id)?("|')?\s*(:|=>|=)\s*("|')?[0-9]{4}\-?[0-9]{4}\-?[0-9]{4}("|')?
AIza[0-9A-Za-z_-]{35}
[0-9]+-[0-9A-Za-z_]{32}\.apps\.googleusercontent\.com
(^|[^0-9A-Za-z/+])1/[0-9A-Za-z_-]{43}
(^|[^0-9A-Za-z/+])1/[0-9A-Za-z_-]{64}
ya29\.[0-9A-Za-z_-]+

The last pattern should have allowed the access token. I committed the code using 'git commit -a --no-verify'

[sdmodi]

Joe/Minhan, would you please review this. I think it also requires the ok-to-test label. Thanks!

[cici37]

/ok-to-test

[cici37]

@sdmodi Here is the documentation for bumping version with latest k/k release: #236 ^^

[freehan]

I would recommend breaking this into 2 commits. One with the go mod changes. The other one with auto generated changes.

[sdmodi]

Split this up into 2 commits.

[sdmodi]

Looks like the build is failing for the following reason:

/root/.cache/bazel/_bazel_prow/64d8524508afe27b4f354a7f46b8c0c3/sandbox/linux-sandbox/545/execroot/io_k8s_cloud_provider_gcp/vendor/go.opentelemetry.io/proto/otlp/collector/metrics/v1/metrics_service_grpc.pb.go:14:11: undefined: grpc.SupportPackageIsVersion7
/root/.cache/bazel/_bazel_prow/64d8524508afe27b4f354a7f46b8c0c3/sandbox/linux-sandbox/545/execroot/io_k8s_cloud_provider_gcp/vendor/go.opentelemetry.io/proto/otlp/collector/metrics/v1/metrics_service_grpc.pb.go:68:37: undefined: grpc.ServiceRegistrar

[sdmodi]

I updated google.golang.org/grpc to v1.32.0 and that got rid of the original error. Now I am seeing a new one:

/workspace/.bazel/sandbox/processwrapper-sandbox/1228/execroot/io_k8s_cloud_provider_gcp/cmd/gke-exec-auth-plugin/request.go:139:48: not enough arguments in call to csr.RequestCertificate
	have (kubernetes.Interface, []byte, string, string, []"k8s.io/cloud-provider-gcp/vendor/k8s.io/api/certificates/v1".KeyUsage, interface {})
	want (kubernetes.Interface, []byte, string, string, *time.Duration, []"k8s.io/cloud-provider-gcp/vendor/k8s.io/api/certificates/v1".KeyUsage, interface {})

[sdmodi]

This is another error for the e2e-full tests:

/root/.cache/bazel/_bazel_prow/64d8524508afe27b4f354a7f46b8c0c3/sandbox/linux-sandbox/591/execroot/io_k8s_cloud_provider_gcp/vendor/go.etcd.io/etcd/client/v3/logger.go:36:40: cannot use zapgrpc.NewLogger(lg) (type *zapgrpc.Logger) as type "k8s.io/cloud-provider-gcp/vendor/google.golang.org/grpc/grpclog".LoggerV2 in argument to "k8s.io/cloud-provider-gcp/vendor/google.golang.org/grpc/grpclog".SetLoggerV2:
	*zapgrpc.Logger does not implement "k8s.io/cloud-provider-gcp/vendor/google.golang.org/grpc/grpclog".LoggerV2 (missing Error method)

[liggitt]

/workspace/.bazel/sandbox/processwrapper-sandbox/1228/execroot/io_k8s_cloud_provider_gcp/cmd/gke-exec-auth-plugin/request.go:139:48: not enough arguments in call to csr.RequestCertificate
	have (kubernetes.Interface, []byte, string, string, []"k8s.io/cloud-provider-gcp/vendor/k8s.io/api/certificates/v1".KeyUsage, interface {})
	want (kubernetes.Interface, []byte, string, string, *time.Duration, []"k8s.io/cloud-provider-gcp/vendor/k8s.io/api/certificates/v1".KeyUsage, interface {})

you can pass nil for the new arg

[liggitt]

it seems likely you'll need to bump to a version newer than 0.22.0 to pick up a compatible version of k8s.io/legacy-cloud-providers that can work with the updated google api library

[k8s-ci-robot]

@sdmodi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
cloud-provider-gcp-e2e-full	7d25eba	link	/test cloud-provider-gcp-e2e-full
cloud-provider-gcp-tests	7d25eba	link	/test cloud-provider-gcp-tests

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sdmodi]

Updating legacy-cloud-providers runs into another problem:

/workspace/.bazel/sandbox/processwrapper-sandbox/769/execroot/io_k8s_cloud_provider_gcp/vendor/github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta/meta.go:602:32: undefined: "k8s.io/cloud-provider-gcp/vendor/google.golang.org/api/compute/v0.beta".ServiceAttachmentsService

What is our usual process for updating k8s.io modules? Is it common to keep running into these issues? Are there a set of modules that we always update in one go.

[cici37]

/workspace/.bazel/sandbox/processwrapper-sandbox/769/execroot/io_k8s_cloud_provider_gcp/vendor/github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta/meta.go:602:32: undefined: "k8s.io/cloud-provider-gcp/vendor/google.golang.org/api/compute/v0.beta".ServiceAttachmentsService

It could be cause by inconsistent of dependency version. k/k is using google.golang.org/api v0.46.0 here while cloud-provider-gcp is with v0.30.0. I believe it could be solved by version update.

[sdmodi]

I have combined this patch with #262 as both need to be updated at the same time for tests to pass.