-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-tpm version to v0.3.2 that supports arm64 #276
Conversation
/assign @mikedanese |
/ok-to-test |
/retest |
|
fe038ff
to
b91f765
Compare
/lgtm |
/retest |
I was trying to say that if you push another commit and trigger |
#273 is merged. Please fetch the latest changes which will unblock e2e failures. Thanks |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikedanese, vinayakankugoyal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Version 0.2.0 of go-tpm library did not support building for linux_arm64. See error below.
The failure above happens because v0.2.0 of the go-tpm library used syscall.SYS_POLL which is not supported in arm64 architecture. To workaround this golang has implemented a shim for poll on arm64 in https://go-review.googlesource.com/c/sys/+/24062/. This issue has been raised in go-tpm library google/go-tpm#146 and was fixed in google/go-tpm#147. Support for arm64 is only available starting v0.3.0 of the go-tpm library. So in order to build gke-exec-auth-plugin for arm64 we will need to update the version of the go-tpm library to v0.3.2.
All changes were produced by running the following command as recommended in the README.md
Tests were also updated because in go-tpm v0.3.0 validation was added to check that the magic value in the attestation data is always 0xff544347. We were not setting the value in our tests and so they were failing with the following error: